Plugins - Do not error in several scenarios that could lead to infinite retries #480
+29
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
requested review from
winder,
asoliman92,
makramkd,
mateusz-sekara,
0xAustinWang,
0xnogo and
b-gopalswami
makramkd
approved these changes
Jan 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin is throwing errors in specific scenarios based on the previousOutcome then in the next rounds the previousOutcome remains the same, leading to infinite retry loops that always lead to errors.
I am returning empty query, observation, outcome and simply log the error to prevent such scenarios.