solana: validate evm extra args #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
requested review from
agusaldasoro,
toblich,
PabloMansanet and
jadepark-dev
jadepark-dev
approved these changes
Jan 22, 2025
PabloMansanet
approved these changes
Jan 22, 2025
| @@ -2374,6 +2379,78 @@ func TestCCIPRouter(t *testing.T) { | |||
| require.Equal(t, uint64(3), ccipMessageSentEvent.Message.Header.Nonce) | |||
| }) | |||
|
|
|||
| t.Run("When gasLimit is too high, it fails", func(t *testing.T) { | |||
There was a problem hiding this comment.
Echoing @toblich's comment on a PR of mine a while ago, this kind of validation can be captured with a Rust unit test rather than the comparatively heavier Go integration test, which I think will help us with iteration time (it's easy to run a single Rust test/group of tests, while the Go suite is more coupled and order-dependent).
I don't have a strong opinion and I wouldn't stop the merge on this, but I'd mildly prefer this to be a Rust unit test instead :).
There was a problem hiding this comment.
ah good point - i will need to do a bit of refactoring here anyway to support multiple types so I will move the tests in the next PR!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate passed in extra args against: