PLEX-250 - WriteReport initial implementation #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
force-pushed
the
PLEX-250
branch
2 times, most recently
from
b35bb06 to
1b825fd
Compare
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
This was referenced Jun 17, 2025
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
Jun 17, 2025
jmank88
reviewed
Jun 17, 2025
jmank88
reviewed
Jun 17, 2025
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
Jun 17, 2025
jmank88
reviewed
Jun 17, 2025
dhaidashenko
previously approved these changes
Jun 26, 2025
jmank88
reviewed
Jun 26, 2025
Comment on lines
+129
to
+134
| // Transaction processing failed due to a network issue, RPC issue, or other fatal error | ||
| TxFatal TransactionStatus = iota | ||
| // Transaction was sent successfully to the chain but the smart contract execution reverted | ||
| TxReverted | ||
| // Transaction was sent successfully to the chain, smart contract executed successfully and mined into a block. | ||
| TxSuccess |
There was a problem hiding this comment.
I'm still confused about pending. It is not always reasonable to wait until a tx is mined, so what do we return when a tx is pending?
Separately, is "mined" the right threshold? As a user of this API, will I be able to wait for finalization?
jmank88
reviewed
Jun 26, 2025
ilija42
reviewed
Jun 26, 2025
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
changing TxStatus enums so success is not 0 improving docs
fixing cap code
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
pablolagreca
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
approved these changes
Jun 26, 2025
dhaidashenko
approved these changes
Jun 26, 2025
ilija42
approved these changes
Jun 26, 2025
bolekk
approved these changes
Jun 26, 2025
|
|
||
| } | ||
|
|
||
| message SignedReport { |
| @@ -108,3 +114,51 @@ type Head struct { | |||
| type TransactionFee struct { | |||
| TransactionFee *big.Int // Cost of transaction in wei | |||
| } | |||
|
|
|||
| type SignedReport struct { | |||
There was a problem hiding this comment.
Where is this used? We already have a proto, why do we need a Go struct as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEX-250(https://smartcontract-it.atlassian.net/browse/PLEX-250
Supports
#1264
smartcontractkit/chainlink-framework#50
smartcontractkit/chainlink-evm#111
smartcontractkit/chainlink#18170
https://github.com/smartcontractkit/capabilities/pull/122