Skip to content

feat: add TONService to Relayer interface #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

briansztamfater
Copy link

@briansztamfater briansztamfater commented Jun 25, 2025

NONEVM-2045

This PR introduces a TONService interface to encapsulate TON-specific functionality and updates the Relayer interface to return a TONService implementation.

@briansztamfater briansztamfater changed the title [WIP] feat: add TONService to Relayer interface feat: add TONService to Relayer interface Jun 26, 2025
@briansztamfater briansztamfater marked this pull request as ready for review June 26, 2025 21:39
@briansztamfater briansztamfater requested a review from a team as a code owner June 26, 2025 21:39
Comment on lines +152 to +154
if tonService, ok := r.(types.TONService); ok {
tonpb.RegisterTONServer(s, newTONServer(tonService, p.BrokerExt))
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@briansztamfater briansztamfater requested a review from archseer June 26, 2025 22:49
Retention time.Duration
}

type Log struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Would it be possible to import from logpoller pkg once it has solid types?

Copy link

@jadepark-dev jadepark-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! left a comments

Comment on lines +131 to +133
if k.evmRelayerSetClient == nil {
return nil, errors.New("evmRelayerSetClient can't be nil")
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if k.evmRelayerSetClient == nil {
return nil, errors.New("evmRelayerSetClient can't be nil")
}
if k.tonRelayerSetClient == nil {
return nil, errors.New("tonRelayerSetClient can't be nil")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants