-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCFR-203] - Improve CR ValComparators to take in arbitrary value #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
force-pushed
the
BCI-3584-valcomp-improvements
branch
from
August 14, 2024 12:40
8819cd8
to
f3e40e7
Compare
ilija42
force-pushed
the
BCI-3584-valcomp-improvements
branch
from
August 22, 2024 13:43
f3e40e7
to
fe3886f
Compare
ilija42
force-pushed
the
BCI-3584-valcomp-improvements
branch
from
August 30, 2024 12:25
de35753
to
0f0b20b
Compare
ilija42
changed the title
Improve CR ValComparators to use any instead of string
Improve CR ValComparators to take in arbitrary value
Aug 30, 2024
ilija42
had a problem deploying
to
integration
September 2, 2024 15:38
— with
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
September 13, 2024 12:37
— with
GitHub Actions
Failure
ilija42
force-pushed
the
BCI-3584-valcomp-improvements
branch
from
September 16, 2024 11:48
89e2d38
to
8a26e61
Compare
ilija42
had a problem deploying
to
integration
September 16, 2024 11:48
— with
GitHub Actions
Failure
ilija42
changed the title
Improve CR ValComparators to take in arbitrary value
[BCFR-203] - Improve CR ValComparators to take in arbitrary value
Sep 16, 2024
EasterTheBunny
approved these changes
Sep 16, 2024
jmank88
approved these changes
Sep 16, 2024
Farber98
approved these changes
Sep 18, 2024
ilija42
had a problem deploying
to
integration
September 18, 2024 14:41
— with
GitHub Actions
Failure
silaslenihan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: 41a0773543e32633a5f41090487e268902dede75
Description
Change Chain Reader Value Comparator filter to any which moves the encoding of value to onchain version to the relayer
Related core PR: smartcontractkit/chainlink#14207