Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring: add jitter to source polling #768

Merged
merged 4 commits into from
Sep 13, 2024
Merged

monitoring: add jitter to source polling #768

merged 4 commits into from
Sep 13, 2024

Conversation

aalu1418
Copy link
Contributor

@aalu1418 aalu1418 commented Sep 13, 2024 •
edited
Loading

  • distribute the load of many requests over +/-20% of the poll period to prevent many simultaneous requests

Resolves Dependencies

jmank88
jmank88 reviewed Sep 13, 2024
View reviewed changes
pkg/monitoring/poller.go Outdated Show resolved Hide resolved
@aalu1418 aalu1418 force-pushed the monitoring/add-jitter-to-polling branch from ed303ec to 65e3cd1 Compare September 13, 2024 16:19
@aalu1418 aalu1418 mentioned this pull request Sep 13, 2024
Merged
@aalu1418 aalu1418 force-pushed the monitoring/add-jitter-to-polling branch from ecb5914 to 4c6270f Compare September 13, 2024 17:02
jmank88
jmank88 previously approved these changes Sep 13, 2024
View reviewed changes
@aalu1418
Copy link
Contributor Author

aalu1418 commented Sep 13, 2024 •
edited
Loading

note: external builds will fail because this was merged before with an interface change: #680

toblich
toblich reviewed Sep 13, 2024
View reviewed changes
pkg/monitoring/poller.go Outdated Show resolved Hide resolved
@aalu1418 aalu1418 merged commit 44d9695 into main Sep 13, 2024
10 checks passed
@aalu1418 aalu1418 deleted the monitoring/add-jitter-to-polling branch September 13, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toblich toblich toblich approved these changes

@jmank88 jmank88 jmank88 approved these changes

@topliceanu topliceanu Awaiting requested review from topliceanu topliceanu is a code owner

@pedrovsg pedrovsg Awaiting requested review from pedrovsg pedrovsg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalu1418 @jmank88 @toblich