bump libocr; add context #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
5fd7326
to
25fc4cb
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
3 times, most recently
from
50cfc58
to
4fc7a43
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
5 times, most recently
from
7e2d94e
to
f0508c0
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
4 times, most recently
from
83921af
to
79f6c4b
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
7f4ec06
to
65c2f9d
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
8f880cc
to
911783c
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
3 times, most recently
from
ad4e313
to
5ec01ac
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
5ec01ac
to
3c01988
Compare
samsondav
previously approved these changes
Oct 8, 2024
| @@ -43,7 +44,7 @@ func UnmarshalJSONStreamValue(enc *JSONStreamValue) (StreamValue, error) { | |||
|
|
|||
| type JSONReportCodec struct{} | |||
|
|
|||
| func (cdc JSONReportCodec) Encode(r Report, _ llotypes.ChannelDefinition) ([]byte, error) { | |||
| func (cdc JSONReportCodec) Encode(ctx context.Context, r Report, _ llotypes.ChannelDefinition) ([]byte, error) { | |||
There was a problem hiding this comment.
Same for this one:
This call goes over GRPC because the codec is implemented in the chain relayer.
There was a problem hiding this comment.
Or maybe in this case, just because some of the interface implementations are in the chain relayers, even if this one is not. (I don't fully grok what this impl is used for)
| @@ -26,7 +27,7 @@ var _ mercury.OnchainConfigCodec = StandardOnchainConfigCodec{} | |||
| // returned by EncodeValueInt192. | |||
| type StandardOnchainConfigCodec struct{} | |||
|
|
|||
| func (StandardOnchainConfigCodec) Decode(b []byte) (mercury.OnchainConfig, error) { | |||
| func (StandardOnchainConfigCodec) Decode(ctx context.Context, b []byte) (mercury.OnchainConfig, error) { | |||
There was a problem hiding this comment.
Again not sure why the codecs need a ctx
There was a problem hiding this comment.
This call goes over GRPC because the codec is implemented in the chain relayer.
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
3c01988
to
fdff613
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
fdff613
to
f5f6ef5
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
f5f6ef5
to
18174ed
Compare
|
@samsondav Updated with real chainlink-common release |
samsondav
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2887
Requires:
Supports: