-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump libocr; add context #52
Conversation
5fd7326
to
25fc4cb
Compare
50cfc58
to
4fc7a43
Compare
7e2d94e
to
f0508c0
Compare
83921af
to
79f6c4b
Compare
7f4ec06
to
65c2f9d
Compare
8f880cc
to
911783c
Compare
ad4e313
to
5ec01ac
Compare
5ec01ac
to
3c01988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -43,7 +44,7 @@ func UnmarshalJSONStreamValue(enc *JSONStreamValue) (StreamValue, error) { | |||
|
|||
type JSONReportCodec struct{} | |||
|
|||
func (cdc JSONReportCodec) Encode(r Report, _ llotypes.ChannelDefinition) ([]byte, error) { | |||
func (cdc JSONReportCodec) Encode(ctx context.Context, r Report, _ llotypes.ChannelDefinition) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this ctx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this one:
This call goes over GRPC because the codec is implemented in the chain relayer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe in this case, just because some of the interface implementations are in the chain relayers, even if this one is not. (I don't fully grok what this impl is used for)
@@ -26,7 +27,7 @@ var _ mercury.OnchainConfigCodec = StandardOnchainConfigCodec{} | |||
// returned by EncodeValueInt192. | |||
type StandardOnchainConfigCodec struct{} | |||
|
|||
func (StandardOnchainConfigCodec) Decode(b []byte) (mercury.OnchainConfig, error) { | |||
func (StandardOnchainConfigCodec) Decode(ctx context.Context, b []byte) (mercury.OnchainConfig, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again not sure why the codecs need a ctx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This call goes over GRPC because the codec is implemented in the chain relayer.
3c01988
to
fdff613
Compare
fdff613
to
f5f6ef5
Compare
f5f6ef5
to
18174ed
Compare
@samsondav Updated with real chainlink-common release |
https://smartcontract-it.atlassian.net/browse/BCF-2887
Requires:
Supports: