SPIKE - feat(chain): introduce AddressToBytes #376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiking - introducing AddressToBytes which converts string to bytes for each of the support chain family. This is originated from [this use case raised by support ticket](https://chainlink-core.slack.com/archives/C08QF1BEW4T/p1756934131485399)
|
|
May be superseeded by #386 soon |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
Context: https://chainlink-core.slack.com/archives/C08QF1BEW4T/p1756934131485399 Design thoughts: Initially i went with [this design](#376) where i introduced the AddressToBytes method to the blockchain interface. However i didn quite like this approach because `AddressToBytes` feels out of place in the blockchain interface (it could be its own interface, and to convert address, we dont need the `chain` struct) and this also forces all implementations of blockchain to implement `AddressToBytes`. So i went with the approach in this PR, introducing a new interface call AddressConverter and using the strategy pattern for each chain to provide the conversion functionality. This decouples the Address conversion logic from the Blockchain interface. This commit adds support for converting string address to bytes for each of the supported chain. ### ToBytes ``` ethChain := e.BlockChains.EVMChains()[0] bytes, err := address.ToBytesForFamily(ethChain.Family(), "0x742d35Cc6634C0532925a3b8D4c8C1B8c4c8C1B8") ``` JIRA: https://smartcontract-it.atlassian.net/browse/CLD-606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spiking - introducing AddressToBytes which converts string to bytes for each of the support chain family.
This is originated from this use case raised by support ticket