Skip to content

Commit

Permalink
cleanup CI + makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
aalu1418 committed Oct 6, 2023
1 parent c6ce327 commit bf5b731
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 33 deletions.
19 changes: 0 additions & 19 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,6 @@ on:
pull_request:

jobs:
golang_lint_ops:
name: Golang Lint
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
- name: Install Nix
uses: cachix/install-nix-action@29bd9290ef037a3ecbdafe83cbd2185e9dd0fa0a # v20
with:
nix_path: nixpkgs=channel:nixos-unstable
- name: golangci-lint
run: nix develop -c make lint-go-ops
- name: Store lint report artifact
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
with:
name: golangci-lint-ops-report
path: ./ops/golangci-lint-ops-report.xml

golang_lint_integration_tests:
name: Golang Lint Integration Tests
runs-on: ubuntu-latest
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/sonar-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,6 @@ jobs:
with:
fetch-depth: 0 # fetches all history for all tags and branches to provide more metadata for sonar reports

- name: Download Golangci ops reports
uses: dawidd6/[email protected]
with:
workflow: golangci-lint.yml
workflow_conclusion: ""
name_is_regexp: true
name: golangci-lint-ops-report
if_no_artifact_found: warn

- name: Download Golangci integration tests reports
uses: dawidd6/[email protected]
with:
Expand Down
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ test_ocr_soak:
gomodtidy:
go mod tidy
cd ./integration-tests && go mod tidy
cd ./ops && go mod tidy

.PHONY: lint-go-ops
lint-go-ops:
cd ./ops && golangci-lint --color=always --exclude=dot-imports --timeout 10m --out-format checkstyle:golangci-lint-ops-report.xml run || true

.PHONY: lint-go-integration-tests
lint-go-integration-tests:
Expand Down

0 comments on commit bf5b731

Please sign in to comment.