Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NONEVM-916] logpoller log processing & decoding #1002

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

[NONEVM-916] logpoller log processing & decoding #1002

wants to merge 27 commits into from

Conversation

reductionista
Copy link
Contributor

JIRA: LINK-916

@reductionista reductionista mentioned this pull request Jan 7, 2025
Closed
@reductionista reductionista force-pushed the NONEVM-916-logpoller-process-decode branch from c208014 to e49250f Compare January 7, 2025 04:28
@reductionista reductionista force-pushed the NONEVM-916-logpoller-process-decode branch from e49250f to 580d1af Compare January 8, 2025 03:06
@reductionista reductionista force-pushed the NONEVM-916-logpoller-process-decode branch from 056e40e to a91f827 Compare January 10, 2025 17:26
@reductionista reductionista marked this pull request as ready for review January 10, 2025 18:47
@reductionista reductionista requested review from a team as code owners January 10, 2025 18:47
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)
5.6% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube

dhaidashenko
dhaidashenko reviewed Jan 10, 2025
View reviewed changes
pkg/solana/logpoller/log_poller.go
TxHash: Signature(blockData.TransactionHash),
}

log.Data, err = base64.StdEncoding.DecodeString(programEvent.Data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors related to decoding should be logged as critical as LP won't be able to ever process the msg.
We might also want just to abandon this log instead of constantly retrying, as we may be able to process other msgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaidashenko dhaidashenko dhaidashenko left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reductionista @dhaidashenko