[WIP] Enable ChainReader to read PDA account state #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
silaslenihan
reviewed
Jan 8, 2025
| )) | ||
| var reader readBinding | ||
| // Create PDA read binding if Seeds config is non-nil | ||
| // Note: Empty seeds list is a valid configuration for a PDA so a length check is intentionally skipped |
There was a problem hiding this comment.
Would an empty seeds list just be a normal account read?
There was a problem hiding this comment.
I think FindProgramAddress still outputs a different programID even with empty seeds since it's still applying the bump seed. I think every PDA in the on-chain code uses some sort of seed though. So guess it wouldn't hurt to also validate empty seeds for our current use case but I wanted to keep this open in case something changes in the future.
| } | ||
|
|
||
| seedByteArray := make([][]byte, 0, len(b.seeds)) | ||
| for _, seed := range b.seeds { |
There was a problem hiding this comment.
thanks for reusing some of the chainwriter seeds functionality! makes it a lot easier to understand both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the ChainReader to read PDA account state
Seedconfig which can be configured as either directly as aValueor as aLocationthat is found in the providedparamsReadDefinitionto include a list ofSeedconfigspdaReadBindingtype with custom logic to calculate PDAs using seeds and the bound program IDreadBinding'sGetAddressmethod to intakeparamsto use for seeds when calculating the PDA