Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated getSeedBytes to handle array seeds #1007

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Updated getSeedBytes to handle array seeds #1007

merged 1 commit into from
Jan 14, 2025

Conversation

silaslenihan
Copy link
Contributor

Description

This PR updated the ChainWriter's PDA parsing capabilities to handle the case where a seed resolves to an array.

This will be necessary for handling CCIP messages which contain multiple token transfers.

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan marked this pull request as ready for review January 10, 2025 17:55
@silaslenihan silaslenihan requested review from a team as code owners January 10, 2025 17:55
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@jadepark-dev jadepark-dev merged commit 74b7a72 into develop Jan 14, 2025
35 checks passed
@jadepark-dev jadepark-dev deleted the getSeedBytes-updates branch January 14, 2025 01:05
amit-momin pushed a commit that referenced this pull request Jan 24, 2025
@silaslenihan @amit-momin
Updated getSeedBytes to handle array seeds (#1007)
7002057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@jadepark-dev jadepark-dev jadepark-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silaslenihan @jadepark-dev @prashantkumar1982 @amit-momin