-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metrics to smoke #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
previously approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just something for the future, but otherwise looks good to me!
Comment on lines
+458
to
+462
ocr2Config := &OCR2Config{ | ||
MinAnswer: "0", | ||
MaxAnswer: "10000000000", | ||
Transmissions: sg.FeedAddress, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something also worth testing in the future: positive and negative values
aalu1418
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocr2:inspect:responses
command to return the last 10 rounds with detailsNew programs have been deployed on testnet and the PRIVATE_KEY will be added to the repo secrets which owns the programs so we don't deploy each time.
There are some repetitions in the job, chain, node creation, marked those as TODO since a bigger refactor will be required since we can't fully port out of using solana CLI with gauntlet due to K8 forwarding having issues with UDP packets. The TODO will decouple the job spec, bridges and all related actions into one method but for now we need testnet daily tests so that will be done in the future.