feat: block history estimator #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
force-pushed
the
feat/block-history-est
branch
from
76e322c
to
1a46fe4
Compare
augustbleeds
reviewed
Jun 5, 2024
| lock sync.RWMutex | ||
| } | ||
|
|
||
| // NewBlockHistoryEstimator creates a new fee estimator that parses historical fees from a fetched block |
There was a problem hiding this comment.
Suggested change
| // NewBlockHistoryEstimator creates a new fee estimator that parses historical fees from a fetched block | |
| // NewBlockHistoryEstimator creates a new fee estimator that parses historical fees from the latest block |
augustbleeds
reviewed
Jun 5, 2024
| @@ -148,9 +148,12 @@ func (txm *Txm) sendWithRetry(chanCtx context.Context, baseTx solanaGo.Transacti | |||
| // https://github.com/gagliardetto/solana-go/blob/main/transaction.go#L252 | |||
| key := baseTx.Message.AccountKeys[0].String() | |||
|
|
|||
| // only calculate base price once | |||
There was a problem hiding this comment.
if bumping occurs after a new block is produced, wouldn't re-calculating the base be helpful?
There was a problem hiding this comment.
that's true - but there is also the possibility that the base value decreases and then the bumped value could be lower than the previous value.
only calculating the base once guarantees that the fee will always increase
aalu1418
force-pushed
the
feat/block-history-est
branch
from
157da2b
to
666b610
Compare
augustbleeds
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCI-2811
upstream:
downstream: