-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCF-3297 Add ContractStateReader to relayer #727
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # integration-tests/go.mod # integration-tests/go.sum
# Conflicts: # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum
# Conflicts: # integration-tests/go.mod
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you need to update the e2e test deps with the core ref
like go get github.com/smartcontractkit/chainlink/integration-tests@<hash>
and
go get github.com/smartcontractkit/chainlink/v2@<hash>
all of the required CI should be able to pass if you are using the core ref: <hash>
in the PR description
# Conflicts: # integration-tests/go.mod # integration-tests/go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me!
i would like to see the common PR merged first so solana has the stable commit hash
# Conflicts: # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum
Quality Gate failedFailed conditions |
Add new
NewContractStateReader
method to relayerCore PR: smartcontractkit/chainlink#13412
core ref: ef5d015eb0cb174828b9953a7547365091797f03