Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCF-3297 Add ContractStateReader to relayer #727

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

george-dorin
Copy link

@george-dorin george-dorin commented May 29, 2024

Add new NewContractStateReader method to relayer
Core PR: smartcontractkit/chainlink#13412

core ref: ef5d015eb0cb174828b9953a7547365091797f03

# Conflicts:
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you need to update the e2e test deps with the core ref

like go get github.com/smartcontractkit/chainlink/integration-tests@<hash> and
go get github.com/smartcontractkit/chainlink/v2@<hash>

all of the required CI should be able to pass if you are using the core ref: <hash> in the PR description

# Conflicts:
#	integration-tests/go.mod
#	integration-tests/go.sum
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me!

i would like to see the common PR merged first so solana has the stable commit hash

@george-dorin george-dorin changed the title Add ContractStateReader to relayer BCF-3297 Add ContractStateReader to relayer Jul 9, 2024
# Conflicts:
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants