Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: deduplicate shared cache logic #803

Merged
merged 3 commits into from
Jul 31, 2024
Merged

cleanup: deduplicate shared cache logic #803

merged 3 commits into from
Jul 31, 2024

Conversation

aalu1418
Copy link
Collaborator

Description

deduplicate shared logic between the transmission + cache logic, potentially reusable for future work

@aalu1418 aalu1418 marked this pull request as ready for review July 23, 2024 09:51
@aalu1418 aalu1418 requested a review from a team as a code owner July 23, 2024 09:51
toblich
toblich reviewed Jul 30, 2024
View reviewed changes
Copy link

@toblich toblich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack a lot of context about the codebase, but this LGTM overall 👍
Just a couple of small questions regarding tiny details

pkg/solana/state_cache.go Outdated Show resolved Hide resolved
pkg/solana/client/cache.go Outdated Show resolved Hide resolved
pkg/solana/client/cache.go Outdated Show resolved Hide resolved
pkg/solana/transmissions_cache.go Outdated Show resolved Hide resolved
pkg/solana/client/cache.go Outdated Show resolved Hide resolved
jadepark-dev
jadepark-dev approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@jadepark-dev jadepark-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aalu1418 aalu1418 enabled auto-merge (squash) July 31, 2024 16:00
toblich
toblich approved these changes Jul 31, 2024
View reviewed changes
Copy link

@toblich toblich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit b3035e3 into develop Jul 31, 2024
28 checks passed
@aalu1418 aalu1418 deleted the cleanup/dedup-cache-logic branch July 31, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadepark-dev jadepark-dev jadepark-dev approved these changes

@toblich toblich toblich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalu1418 @toblich @jadepark-dev