Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gomods; add make generate; add CI check for tidiness+generation #814

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 6, 2024

This PR swaps in gomods for tidy and generate commands, updates stale generated files, and adds a CI check for tidiness+generation.

@jmank88
Copy link
Contributor Author

jmank88 commented Aug 6, 2024

This has revealed some kind of inconsistency between local dev and CI with mockery generation.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
26.9% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@jmank88 jmank88 marked this pull request as ready for review August 6, 2024 12:31
@jmank88 jmank88 requested review from a team as code owners August 6, 2024 12:31
@jmank88 jmank88 requested a review from aalu1418 August 6, 2024 12:31
@aalu1418 aalu1418 enabled auto-merge (squash) August 6, 2024 13:33
@aalu1418 aalu1418 merged commit f7284df into develop Aug 6, 2024
27 of 28 checks passed
@aalu1418 aalu1418 deleted the gomods branch August 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants