Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test coverage on reimbursement tests #822

Merged
merged 1 commit into from
Aug 19, 2024
Merged

improve test coverage on reimbursement tests #822

merged 1 commit into from
Aug 19, 2024

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Aug 16, 2024 •
edited
Loading

Description

https://smartcontract-it.atlassian.net/browse/BCI-2810

Improve test coverage on program reimbursement calculations with additional edge cases

also ran a yarn format hence some of the extra lines

@aalu1418 aalu1418 requested a review from a team as a code owner August 16, 2024 21:36
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

toblich
toblich approved these changes Aug 19, 2024
View reviewed changes
Copy link

@toblich toblich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack some context on the code here, but I've reviewed the code changes and it LGTM 👍

@aalu1418 aalu1418 merged commit 43e8f68 into develop Aug 19, 2024
32 of 33 checks passed
@aalu1418 aalu1418 deleted the contracts/improve-reimbursement-cov branch August 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toblich toblich toblich approved these changes

@archseer archseer Awaiting requested review from archseer

@jadepark-dev jadepark-dev Awaiting requested review from jadepark-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalu1418 @toblich