Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RPC Client Methods #845

Merged
merged 91 commits into from
Oct 17, 2024
Merged

Implement RPC Client Methods #845

merged 91 commits into from
Oct 17, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Sep 6, 2024 •
edited
Loading

Description

Implemented the RPCClient interface as part of the Solana Client to enable the use of MultiNode.
Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-298

@DylanTinianov DylanTinianov self-assigned this Sep 6, 2024
aalu1418
aalu1418 reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me! just a question on how the underlying block ingestion works

@aalu1418 aalu1418 enabled auto-merge (squash) October 17, 2024 14:46
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
11 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 665f519 into develop Oct 17, 2024
35 checks passed
@aalu1418 aalu1418 deleted the BCFR-298-multinode-client branch October 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@dhaidashenko dhaidashenko dhaidashenko approved these changes

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DylanTinianov @patrick-dowell @dhaidashenko @aalu1418