Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply unimplemented to contract reader #854

Merged
merged 6 commits into from
Sep 13, 2024
Merged

apply unimplemented to contract reader #854

merged 6 commits into from
Sep 13, 2024

Conversation

EasterTheBunny
Copy link
Contributor

Description

Introducing unimplemented implementation to ContractReader interface.

Requires Dependencies

Resolves Dependencies

@EasterTheBunny EasterTheBunny requested a review from a team as a code owner September 12, 2024 21:18
@EasterTheBunny EasterTheBunny mentioned this pull request Sep 12, 2024
Merged
@EasterTheBunny EasterTheBunny requested a review from a team as a code owner September 13, 2024 16:25
Farber98
Farber98 previously approved these changes Sep 13, 2024
View reviewed changes
aalu1418
aalu1418 previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good! just need some core bumps and the core_ref in the integration tests to pass CI

@aalu1418 aalu1418 enabled auto-merge (squash) September 13, 2024 18:56
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 756da9c into develop Sep 13, 2024
33 checks passed
@aalu1418 aalu1418 deleted the unimplemented_contract_reader branch September 13, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@Farber98 Farber98 Farber98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EasterTheBunny @Farber98 @aalu1418