-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NONEVM-714] [solana] - Add multiple blocks aggregation functionality to Block History Estimator #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-momin
reviewed
Oct 31, 2024
Farber98
commented
Oct 31, 2024
Farber98
commented
Oct 31, 2024
amit-momin
approved these changes
Nov 1, 2024
silaslenihan
approved these changes
Nov 1, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR Introduces the
MultipleBlocksEstimator
that tries to get thedesiredBlockCount
most recent blocks to determine a more stable compute unit price.How It Works:
Configuration:
BlockHistorySize
is used to configure this estimator.Fetch Recent Blocks: Tries to retrieve specified number of the latest confirmed blocks from latest slots based on the configured
BlockHistorySize
. Not all slots have a block.Concurrent Processing:: Fetches each block concurrently while limiting the number of simultaneous operations to prevent rate limiting.
Extract and Aggregate Fees: Parses each block to extract compute unit prices from transactions. Calculates the median compute unit price for each block.
Determine Overall Average: Aggregates the median prices from all fetched blocks. Computes the overall average to set as the current base compute unit price, ensuring it stays within predefined minimum and maximum config limits.
Merge together with: