-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor so txm owns blockhash assignment #928
Draft
Farber98
wants to merge
6
commits into
develop
Choose a base branch
from
nonevm-706-support-custom-bumping-strategy-rpc-expiration-within-confirmation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor so txm owns blockhash assignment #928
Farber98
wants to merge
6
commits into
develop
from
nonevm-706-support-custom-bumping-strategy-rpc-expiration-within-confirmation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-rpc-expiration-within-confirmation
Quality Gate passedIssues Measures |
until this point, only refactor of existing logic:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 1:
transmitter
andchain
totxm
. Needed to track expiration in Part 2.sendWithRetry
complexity by dividing logic into smaller helper funcs. It was really hard to follow and had a lot of responsibilities.Part 2:
TxExpirationTimeout
, retrieves theslotHeight
and checks if txes in ourbroadcastedMap
that are in abroadcasted
state have expired.lastValidBlockHeight
to thependingTx
when we create it. This allows us to compare theslotHeight
to see if it has exceeded that value and decide if we need to rebuild and rebroadcast the transaction.sendWithRetry
function.Remove()
sendWithRetry
with ithttps://smartcontract-it.atlassian.net/browse/NONEVM-706