Monitoring #103

topliceanu · 2022-09-05T14:23:29Z

No description provided.

github-actions · 2022-09-05T14:42:51Z

Smoke Test Results

1 tests 1 ✔️ 7m 2s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 9126230.

♻️ This comment has been updated with latest results.

pedrovsg · 2022-09-07T13:23:02Z

relayer/ops/monitoring/Dockerfile

+
+# Production image
+
+FROM ubuntu:20.04


I would recommend alpine

I agree. I added a TODO to update this at a later point. It shouldn't require any other changes. I'll use this https://github.com/smartcontractkit/atlas/blob/master/evm/Dockerfile as an example. Wdyt?

I wonder if you need alpine and scratch could be enough?

As long as you

# copy ca certs COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/

I'll do this in a separate PR. Wdyt?

relayer/pkg/chainlink/ocr2/client.go

relayer/pkg/chainlink/ocr2/types.go

relayer/pkg/monitoring/config_chain.go

relayer/pkg/monitoring/source_envelope.go

archseer · 2022-09-13T01:16:12Z

relayer/ops/monitoring/Dockerfile

+FROM ubuntu:20.04 AS build
+
+# OS dependencies
+RUN apt-get update && apt-get install -y wget gcc build-essential git
+
+# Copy source
+
+RUN mkdir -p /starknet-monitoring/relayer
+COPY ./relayer /starknet-monitoring/relayer
+
+# Install golang
+
+RUN wget -c https://dl.google.com/go/go1.18.1.linux-amd64.tar.gz -O - \
+  | tar -xz -C /usr/local \
+  && mkdir -p /go/src /go/bin
+ENV PATH /usr/local/go/bin:$PATH
+
+# Compile binary
+
+WORKDIR /starknet-monitoring/relayer
+RUN go build -o ./monitoring ./cmd/monitoring/*.go


Since all this is doing is just compiling go code, why not use the golang build image like core does?

https://github.com/smartcontractkit/chainlink/blob/b64fe315a2e7af10244f737c9acd7bd3c75bbeef/core/chainlink.Dockerfile#L30

I'll do this in a separate PR. Wdyt?

topliceanu · 2022-09-16T09:20:17Z

@archseer you marked your review as "requesting changes". What is exactly that you want me to change? the Dockerfile?

archseer · 2022-09-16T09:25:16Z

Yeah it should be a small change that speeds up the build.

…

On Fri, 16 Sep 2022, at 18:20, Alexandru Topliceanu wrote: @archseer <https://github.com/archseer> you marked your review as "requesting changes". What is exactly that you want me to change? the Dockerfile? — Reply to this email directly, view it on GitHub <#103 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKPF5XK5VLQDR5GUA56VADV6Q3VXANCNFSM6AAAAAAQFBMWXA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

relayer/ops/monitoring/Dockerfile

relayer/go.mod

relayer/pkg/chainlink/ocr2/client.go

relayer/pkg/monitoring/config_feed.go

Envelope test

…2.Client

events

aalu1418

looking good! just small things :)

monitoring/go.mod

relayer/pkg/chainlink/ocr2/types_test.go

monitoring/ops/Dockerfile

aalu1418

looks good to me! happy to approve knowing there will be follow up PRs :)

NOTE: this PR should not be squashed - commit history needs to be preserved

"Dismiss" is a strong word! I'll update the Dockerfile in a separate PR.

topliceanu mentioned this pull request Sep 5, 2022

Monitoring #63

Closed

topliceanu temporarily deployed to integration September 5, 2022 14:34 Inactive

topliceanu requested review from krebernisak and aalu1418 September 6, 2022 07:03

pedrovsg reviewed Sep 7, 2022

View reviewed changes

sdrug reviewed Sep 7, 2022

View reviewed changes

relayer/pkg/chainlink/ocr2/client.go Show resolved Hide resolved

relayer/pkg/chainlink/ocr2/types.go Show resolved Hide resolved

relayer/pkg/monitoring/config_chain.go Outdated Show resolved Hide resolved

relayer/pkg/monitoring/source_envelope.go Outdated Show resolved Hide resolved

topliceanu temporarily deployed to integration September 12, 2022 13:00 Inactive

topliceanu temporarily deployed to integration September 12, 2022 13:09 Inactive

archseer previously requested changes Sep 13, 2022

View reviewed changes

topliceanu had a problem deploying to integration September 16, 2022 09:05 Failure

topliceanu had a problem deploying to integration September 16, 2022 09:18 Failure

topliceanu had a problem deploying to integration September 16, 2022 09:23 Failure

aalu1418 reviewed Sep 20, 2022

View reviewed changes

relayer/ops/monitoring/Dockerfile Outdated Show resolved Hide resolved

relayer/go.mod Outdated Show resolved Hide resolved

relayer/pkg/chainlink/ocr2/client.go Outdated Show resolved Hide resolved

relayer/pkg/monitoring/config_feed.go Outdated Show resolved Hide resolved

topliceanu force-pushed the monitoring-v2 branch from 4029706 to 0dff787 Compare September 23, 2022 14:03

topliceanu had a problem deploying to integration September 23, 2022 14:04 Failure

topliceanu had a problem deploying to integration September 26, 2022 17:07 Failure

topliceanu had a problem deploying to integration September 27, 2022 11:44 Failure

topliceanu had a problem deploying to integration September 27, 2022 14:25 Failure

topliceanu had a problem deploying to integration September 27, 2022 17:15 Error

topliceanu had a problem deploying to integration September 27, 2022 17:21 Failure

topliceanu had a problem deploying to integration September 27, 2022 18:36 Failure

topliceanu had a problem deploying to integration September 27, 2022 18:50 Error

topliceanu had a problem deploying to integration September 27, 2022 18:52 Failure

topliceanu had a problem deploying to integration September 27, 2022 19:11 Error

topliceanu had a problem deploying to integration September 27, 2022 19:21 Error

topliceanu had a problem deploying to integration September 27, 2022 19:28 Failure

topliceanu had a problem deploying to integration September 27, 2022 21:20 Error

topliceanu added 11 commits September 30, 2022 10:49

add test for NewRoundData and fix latest transmission timestamp in the

c44cb8f

Envelope test

appease the linter

33bde04

move monitoring into a separate module along with the dockerfile

d00fb60

fix bug where multiply was not correctly populated

b004eee

fix broken transmitter address in Envelope source test

6e194cf

remove markdown and fix unit test for NewRoundData

5439e69

support multiple new_transmission events in a single block in the ocr…

a8e54e0

…2.Client

fix in ocr2.Client#NewTransmissionsFromEventsAt now returns multiple

d561a42

events

upgrade to the latest version of chainlink-relay

39e10c7

make the e2e test pass

99519c2

make the ocr2.Client tests pass

1b80974

topliceanu force-pushed the monitoring-v2 branch from 8c5a40f to 1b80974 Compare September 30, 2022 10:01

topliceanu had a problem deploying to integration September 30, 2022 10:01 Failure

topliceanu had a problem deploying to integration September 30, 2022 10:11 Failure

bump the testing framework

32f73fa

topliceanu temporarily deployed to integration September 30, 2022 13:50 Inactive

topliceanu temporarily deployed to integration September 30, 2022 13:56 Inactive

aalu1418 reviewed Sep 30, 2022

View reviewed changes

monitoring/go.mod Outdated Show resolved Hide resolved

relayer/pkg/chainlink/ocr2/types_test.go Outdated Show resolved Hide resolved

relayer/pkg/chainlink/ocr2/types_test.go Outdated Show resolved Hide resolved

monitoring/ops/Dockerfile Show resolved Hide resolved

move utility to relayer/pkg/starknet and rename to StringsToJunoFelts

b90403e

topliceanu temporarily deployed to integration October 3, 2022 16:15 Inactive

topliceanu requested a review from aalu1418 October 3, 2022 16:16

topliceanu had a problem deploying to integration October 3, 2022 16:21 Error

updated starknet relayer to a commit in this PR

9126230

topliceanu temporarily deployed to integration October 3, 2022 16:26 Inactive

topliceanu temporarily deployed to integration October 3, 2022 16:31 Inactive

aalu1418 mentioned this pull request Oct 3, 2022

Change monitoring base container to alpine #145

Open

aalu1418 approved these changes Oct 3, 2022

View reviewed changes

topliceanu merged commit 471b1fb into develop Oct 4, 2022

topliceanu deleted the monitoring-v2 branch October 4, 2022 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monitoring #103

Monitoring #103

topliceanu commented Sep 5, 2022

github-actions bot commented Sep 5, 2022 •

edited

Loading

pedrovsg Sep 7, 2022

topliceanu Sep 12, 2022

archseer Sep 13, 2022 •

edited

Loading

topliceanu Sep 28, 2022

archseer Sep 13, 2022

topliceanu Sep 28, 2022

topliceanu commented Sep 16, 2022

archseer commented Sep 16, 2022 via email

aalu1418 left a comment

aalu1418 left a comment

Monitoring #103

Monitoring #103

Conversation

topliceanu commented Sep 5, 2022

github-actions bot commented Sep 5, 2022 • edited Loading

Smoke Test Results

pedrovsg Sep 7, 2022

Choose a reason for hiding this comment

topliceanu Sep 12, 2022

Choose a reason for hiding this comment

archseer Sep 13, 2022 • edited Loading

Choose a reason for hiding this comment

topliceanu Sep 28, 2022

Choose a reason for hiding this comment

archseer Sep 13, 2022

Choose a reason for hiding this comment

topliceanu Sep 28, 2022

Choose a reason for hiding this comment

topliceanu commented Sep 16, 2022

archseer commented Sep 16, 2022 via email

aalu1418 left a comment

Choose a reason for hiding this comment

aalu1418 left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2022 •

edited

Loading

archseer Sep 13, 2022 •

edited

Loading