Check if observations sorted before taking median #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
force-pushed
the
fix/observations-sort
branch
from
c77ac67
to
551329e
Compare
aalu1418
reviewed
Oct 17, 2022
Comment on lines
+124
to
+130
| // Check if the report contains sorted observations | ||
| _less := func(i, j int) bool { | ||
| return oo[i].Cmp(oo[j]) < 0 | ||
| } | ||
| sorted := sort.SliceIsSorted(oo, _less) | ||
| if !sorted { | ||
| return nil, errors.New("observations not sorted") |
There was a problem hiding this comment.
test case? otherwise, this looks great!
There was a problem hiding this comment.
Yeah, but it's more involved than adding a simple test case (BuildReport always sorts, custom fuzzer could be built) so I'll defer to this GitHub Issue for now: #171
krebernisak
force-pushed
the
fix/observations-sort
branch
from
551329e
to
f8fbcd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.