Added range checks in event parsers. Issue #180 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
previously approved these changes
Dec 13, 2022
relayer/pkg/chainlink/ocr2/events.go
Outdated
Comment on lines
53
to
59
| func rangeCheck(felt *caigotypes.Felt, lowerBound *big.Int, upperBound *big.Int) error { | ||
| if !(felt.Int.Cmp(lowerBound) >= 0 && felt.Int.Cmp(upperBound) <= 0) { | ||
| return errors.New("invalid: value is out of range") | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
nit: let's structure this utility as an object we can reuse:
type Range struct {
Lower *big.Int
Upper *big.Int
}
// Notice: we don't pass in Felt here and we keep this fn more generic
func (r *Range) Check(n *big.Int) (error) {
if !(n.Int.Cmp(r.Lower) >= 0 && n.Int.Cmp(r.Upper) <= 0) {
return fmt.Errorf("invalid: value %v is out of range [%v,%v]", n, r.Lower, r.Upper)
}
return nil
}Which will allow for less boilerplate:
err := uint64Range.Check(eventData[observationsLenIndex])
if err != nil {
return NewTransmissionEvent{}, err
}
taco-paco
force-pushed
the
issue/event-parsers
branch
from
580925b
to
a078f6f
Compare
taco-paco
temporarily deployed
to
integration
GitHub Actions
Inactive
taco-paco
temporarily deployed
to
integration
GitHub Actions
Inactive
taco-paco
temporarily deployed
to
integration
GitHub Actions
Inactive
taco-paco
temporarily deployed
to
integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.