Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to libocr master 2271752fa829 #313

Closed
wants to merge 3 commits into from
Closed

Bump to libocr master 2271752fa829 #313

wants to merge 3 commits into from

Conversation

samsondav
Copy link
Contributor

No description provided.

@aalu1418 aalu1418 self-requested a review August 3, 2023 14:39
jmank88
jmank88 previously approved these changes Aug 3, 2023
View reviewed changes
@bolekk
Copy link
Contributor

bolekk commented Aug 3, 2023

I think you also need to bump chainlink core to something much fresher than @v2.2.0-mercury-20230608.0.20230610030307-281eedc27b1f

bolekk
bolekk requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsondav the old core dep here is no longer compatible with newest relay - you need to bump core too.

@jmank88 jmank88 requested a review from bolekk August 3, 2023 23:52
@bolekk
Copy link
Contributor

bolekk commented Aug 4, 2023

hmmmm, we might need to wait for this smartcontractkit/chainlink#10054 and then update core again...? I'm confused about the message in failures here but let's do that and see.

@bolekk bolekk temporarily deployed to integration August 7, 2023 21:33 — with GitHub Actions Inactive
@bolekk bolekk temporarily deployed to integration August 7, 2023 21:33 — with GitHub Actions Inactive
@bolekk
Copy link
Contributor

bolekk commented Aug 7, 2023

Bumped dep versions again and now getting a completely different error :) @aalu1418 help please!

146.7 common/test_common.go:97:27: undefined: client.Chainlink
146.7 common/test_common.go:214:54: undefined: client.Chainlink
146.7 common/common.go:123:95: undefined: client.Chainlink
146.7 common/common.go:128:47: cannot use ChainlinkNodes (variable of type []"github.com/smartcontractkit/chainlink/integration-tests/client".ChainlinkK8sClient) as []"github.com/smartcontractkit/chainlink/integration-tests/client".ChainlinkClient value in argument to client.CreateNodeKeysBundle

@aalu1418
Copy link
Collaborator

aalu1418 commented Aug 7, 2023

Bumped dep versions again and now getting a completely different error :) @aalu1418 help please!

146.7 common/test_common.go:97:27: undefined: client.Chainlink 146.7 common/test_common.go:214:54: undefined: client.Chainlink 146.7 common/common.go:123:95: undefined: client.Chainlink 146.7 common/common.go:128:47: cannot use ChainlinkNodes (variable of type []"github.com/smartcontractkit/chainlink/integration-tests/client".ChainlinkK8sClient) as []"github.com/smartcontractkit/chainlink/integration-tests/client".ChainlinkClient value in argument to client.CreateNodeKeysBundle

@smickovskid are the starknet e2e tests just in a broken state for starknet?

@archseer
Copy link
Collaborator

archseer commented Aug 7, 2023

Code should build but I'm doing maintenance in my PR, the devnet now expects much never cairo versions: #310

@archseer
Copy link
Collaborator

archseer commented Aug 7, 2023

Might need this cherry-pick: 579aa3d

@aalu1418
Copy link
Collaborator

aalu1418 commented Aug 9, 2023

will close this PR once this PR is merged: #317
(duplicated and e2e tests fixed in the other PR)

@aalu1418 aalu1418 closed this Aug 10, 2023
@archseer archseer deleted the bump_libocr_2271752fa829 branch January 22, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 left review comments

@archseer archseer Awaiting requested review from archseer

@aalu1418 aalu1418 Awaiting requested review from aalu1418

@bolekk bolekk Awaiting requested review from bolekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samsondav @bolekk @aalu1418 @archseer @jmank88