BCI-1780: Failed Tx Inclusion RPC Changes #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Failure
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Sep 18, 2023
| @@ -388,6 +388,8 @@ require ( | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/NethermindEth/starknet.go => github.com/augustbleeds/starknet.go v0.4.2-0.20230912155424-048179bee72e | |||
There was a problem hiding this comment.
Remove?
Or group below and add a comment? And would it be worth creating a smartcontkit/strknet.go fork repo?
There was a problem hiding this comment.
thanks for the review, the replace was just meant to be a temp solution. I can remove it now because starknet.go has merged the changes into their repo!
|
Subsumed by #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.