BCI-1923: Cairo Test Upgradeable

[augustbleeds]

Changes

• Introduce 2 mock contracts (for testing purposes)
• Uncomments ignore macro to test upgradeability functionality
• Adds additional test that deploys and upgrades a contract and tests the function calls are as expected

note: we'll need to change these tests once contract composition is introduced because this will change the way we compose the Upgradeable module. See https://community.starknet.io/t/cairo-1-contract-syntax-is-evolving/94794?page=2#extensibility-and-components-11 for the proposed #[starknet::component] macro

[archseer]

Contract builds fail in a weird way. Maybe we need to bump the scarb version on CI?

[augustbleeds]

Contract builds fail in a weird way. Maybe we need to bump the scarb version on CI?

Thanks, I fixed the issue. It was failing locally too. I pinpointed the issue to the constructor of the mock contracts, which need to have a mutable reference instead of a snapshot to the contract state even if they are not writing anything to storage.

I also made some changes to implement the IUpgradeable trait. Do you think we should remove the upgrade function from the Multisig interface?

[archseer]

Yeah I think that's fine, since we're no longer upstreaming the contract we can just implement IUpgradeable 👍🏻

[cl-sonarqube-production]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information