Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing E2E tests #349

Closed
wants to merge 9 commits into from
Closed

Fixing E2E tests #349

wants to merge 9 commits into from

Conversation

smickovskid
Copy link
Contributor

No description provided.

@smickovskid smickovskid changed the base branch from develop to update-dependencies January 31, 2024 08:38
archseer
archseer reviewed Feb 6, 2024
View reviewed changes
ops/devnet/devnet.go
@@ -105,7 +105,7 @@ func (devnet *StarknetDevnetClient) FundAccounts(l2AccList []string) error {
for _, key := range l2AccList {
res, err := devnet.client.R().SetBody(map[string]any{
"address": key,
"amount": 1e21,
"amount": 9000000000000000000000.0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw this whole file could be replaced with starknet.go helpers: https://github.com/NethermindEth/starknet.go/blob/main/devnet/devnet.go#L122

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@archseer
Copy link
Collaborator

archseer commented Feb 8, 2024

Merged into #343

@archseer archseer closed this Feb 8, 2024
@archseer archseer deleted the BCI-2621-new branch February 8, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smickovskid @archseer