Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci #356

Merged
merged 39 commits into from
Mar 12, 2024
Merged

Fix ci #356

merged 39 commits into from
Mar 12, 2024

Conversation

smickovskid
Copy link
Contributor

Fix ci

@smickovskid smickovskid changed the base branch from develop to update-dependencies February 14, 2024 14:42
@smickovskid smickovskid changed the base branch from update-dependencies to develop February 14, 2024 14:50
@smickovskid smickovskid changed the base branch from develop to update-dependencies February 14, 2024 14:50
cfal
cfal reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@cfal cfal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left one more comment on docker cleanup. also, go relayer lint is failing (perhaps caused by my fix 😅)

integration-tests/smoke/ocr2_test.go
// K8s specific config and cleanup
if *config.Common.InsideK8s {
t.Cleanup(func() {
if err = actions.TeardownSuite(t, state.Common.Env, state.ChainlinkNodesK8s, nil, zapcore.PanicLevel, nil); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify - if i'm running this locally, and i already have docker running on my machine with unrelated containers, does it clean up these terst containers that are started here?

@archseer archseer marked this pull request as ready for review March 12, 2024 04:58
@archseer archseer merged commit fb70e9d into develop Mar 12, 2024
15 of 16 checks passed
@archseer archseer deleted the fix_ci branch March 12, 2024 05:09
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
71 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel left review comments

@cfal cfal cfal left review comments

@archseer archseer archseer left review comments

@augustbleeds augustbleeds Awaiting requested review from augustbleeds

@chris-de-leon-cll chris-de-leon-cll Awaiting requested review from chris-de-leon-cll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smickovskid @archseer @cfal @Tofel