-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCI-2538]: Updates Examples Directory #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-de-leon-cll
temporarily deployed
to
integration
February 28, 2024 04:32
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
February 28, 2024 04:32
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
February 28, 2024 04:32
— with
GitHub Actions
Inactive
chris-de-leon-cll
had a problem deploying
to
integration
February 28, 2024 04:44
— with
GitHub Actions
Error
chris-de-leon-cll
had a problem deploying
to
integration
February 28, 2024 04:44
— with
GitHub Actions
Failure
… import, updates test cases
chris-de-leon-cll
temporarily deployed
to
integration
February 29, 2024 20:39
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
February 29, 2024 20:39
— with
GitHub Actions
Inactive
chris-de-leon-cll
had a problem deploying
to
integration
February 29, 2024 20:39
— with
GitHub Actions
Failure
chris-de-leon-cll
temporarily deployed
to
integration
February 29, 2024 21:19
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
February 29, 2024 21:19
— with
GitHub Actions
Inactive
chris-de-leon-cll
had a problem deploying
to
integration
February 29, 2024 21:19
— with
GitHub Actions
Failure
archseer
reviewed
Mar 1, 2024
chris-de-leon-cll
temporarily deployed
to
integration
March 1, 2024 22:08
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
March 1, 2024 22:08
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
March 1, 2024 22:09
— with
GitHub Actions
Inactive
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:20
— with
GitHub Actions
Error
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:20
— with
GitHub Actions
Failure
…n for running example test cases with starknet foundry, removes test-integration-contracts
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:25
— with
GitHub Actions
Error
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:25
— with
GitHub Actions
Error
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:25
— with
GitHub Actions
Error
chris-de-leon-cll
had a problem deploying
to
integration
March 1, 2024 22:27
— with
GitHub Actions
Failure
chris-de-leon-cll
temporarily deployed
to
integration
March 1, 2024 22:27
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
March 1, 2024 22:27
— with
GitHub Actions
Inactive
…actkit/chainlink-starknet into feat/BCI-2538-update-examples
chris-de-leon-cll
temporarily deployed
to
integration
March 5, 2024 22:34
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
March 5, 2024 22:34
— with
GitHub Actions
Inactive
chris-de-leon-cll
temporarily deployed
to
integration
March 5, 2024 22:34
— with
GitHub Actions
Inactive
chris-de-leon-cll
had a problem deploying
to
integration
March 5, 2024 22:46
— with
GitHub Actions
Failure
chris-de-leon-cll
had a problem deploying
to
integration
March 5, 2024 22:46
— with
GitHub Actions
Failure
Quality Gate passedIssues Measures |
archseer
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
chris-de-leon-cll
changed the title
Updates Examples Directory
[BCI-2538]: Updates Examples Directory
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
proxy-consumer
aggregator_consumer
withstarknet-foundry
integratedaggregator-consumer
example folder (keeping this around for reference - will remove it once everything has been updated)consumer.cario
andprice_consumer.cairo
contracts for compatibility with cairo v2.5.4consumer.cairo
andprice_consumer.cairo
- every function on both of these contracts has a corresponding test casesnforge
(so that users can see how the contracts work via a local devnet)consumerValidator.ts
- not applicable (this doesn't useconsumer.cairo
orprice_consumer.cairo
)deploy_accounts.ts
- not applicable (handled programmatically in cairo test cases)deploy_contracts.ts
- the test cases have helper functions which use the snforge library to compile and deploy contractsreadContinuously.ts
- not applicable (this runs an infinite loop that reads the latest round data every 3 seconds)readDecimals.ts
- has a corresponding cairo test casereadLatestRound.ts
- has a corresponding cairo test caseupdateLatestRound.ts
- has a corresponding cairo test case.github/install-starknet-foundry/action.yml
) that installsstarknet-foundry
.github/workflow/examples.yml
) that runs theaggregator_consumer
example test cases viasnforge test
packages-ts/starknet
test-integration-contracts
Delayed (will be tackled in a follow up PR)
sncast
scripts that interact with starknet testnet (so that users can see how the contracts work against a live network)consumerValidator.ts
deploy_accounts.ts
deploy_contracts.ts
readContinuously.ts
readDecimals.ts
readLatestRound.ts
updateLatestRound.ts
Known Issues / Limitations
address.is_zero()
have been commented out due to compile errors - looking into why these are occurring even when thezeroable
module is importededition
property fromScarb.toml
, which was automatically added bysnforge init
:chainlink-starknet/contracts
folder have been copied into the examples directory and modified slightly for compatibility withsnforge
. All the modifications are minor - they mostly involved creating new interfaces for dispatchers and renaming import paths. Also, to elaborate more on "compatibility forsnforge
", the test cases use a functiondeclare(<ContractName>)
for contract deployment, and this function only works if references a contract that is exported from thelib.cairo
file in thesrc
folder. I'm curious to understand if there's a better way to reference the original contracts without having to duplicate them in theexamples
folderedition
field fromScarb.toml
(see above) and to also add the following toScarb.toml
so that the tests could find the contract artifacts: