read pending block not latest #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
approved these changes
Jun 14, 2024
archseer
previously requested changes
Jun 14, 2024
thanks, it was missing a mocked response |
augustbleeds
dismissed
archseer’s stale review
blaz's request has been satisfied
chris-de-leon-cll
approved these changes
Jul 30, 2024
|
augustbleeds
added a commit
that referenced
this pull request
Aug 1, 2024
augustbleeds
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pending block contains finalized txs so it should be used for the most recent data
if you read from the pending block, there's a problem where the block number on chain is actually not queryable via the rpc because the block hasn't been assigned a block number since it's in the
pendingstate. a fix has been made to account for this edge case