Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCI-3898: fix multisig set config bug #497

Merged
merged 5 commits into from
Aug 1, 2024
Merged

BCI-3898: fix multisig set config bug #497

merged 5 commits into from
Aug 1, 2024

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented Jul 31, 2024 •
edited
Loading

Two bugs related to multisig set config detailed here

https://smartcontract-it.atlassian.net/browse/BCI-3898

Changes:

  • You now need to pass in --randomSecret as a flag or an enviornment variable (RANDOM_SECRET) to call ocr2:set_config
  • Wrapped multisig commands will write the config digest to RDD now if the underlying call is to set_config

Commands were verified on testnet

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@augustbleeds augustbleeds merged commit ef54507 into develop Aug 1, 2024
20 of 21 checks passed
@augustbleeds augustbleeds deleted the augustus.BCI-3898.fix-multisig-set-config branch August 1, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-de-leon-cll chris-de-leon-cll chris-de-leon-cll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustbleeds @chris-de-leon-cll