bump ctf #498
Merged
bump ctf #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Aug 1, 2024
| @@ -79,7 +79,7 @@ require ( | |||
| github.com/cespare/xxhash v1.1.0 // indirect | |||
| github.com/cespare/xxhash/v2 v2.2.0 // indirect | |||
| github.com/chai2010/gettext-go v1.0.2 // indirect | |||
| github.com/chaos-mesh/chaos-mesh/api/v1alpha1 v0.0.0-20220226050744-799408773657 // indirect | |||
| github.com/chaos-mesh/chaos-mesh/api v0.0.0-20240709130330-9f4feec7553f // indirect | |||
There was a problem hiding this comment.
I had to manually align this one with CTF to get the mod resolution to work.
There was a problem hiding this comment.
just a guess, do you need to add this line? I had to add a bunch of things to the integration test go.mod a while back for solana
exclude github.com/chaos-mesh/chaos-mesh/api/v1alpha1 v0.0.0-20220226050744-799408773657
There was a problem hiding this comment.
That would have helped since I replaced that version with this one. I think it is only a problem because the tooling assumes that import paths won't step on each other, so each package only belong to one module. Should be fine now that we are past it.
|
aalu1418
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.