BCI-4128: Use Starknet-Foundry #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
had a problem deploying
to
integration
GitHub Actions
Error
augustbleeds
commented
Aug 30, 2024
| @@ -1,14 +1,74 @@ | |||
| # Code generated by scarb DO NOT EDIT. | |||
| version = 1 | |||
|
|
|||
| [[package]] | |||
There was a problem hiding this comment.
adding this to make sure alexandria package compiles for mcms
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Comment on lines
+11
to
+13
| # [scripts] | ||
| # test = "snforge test" | ||
|
|
There was a problem hiding this comment.
We probably don't need this either right?
There was a problem hiding this comment.
yeah, we don't. i might add it though to make use of scarb test
Comment on lines
+148
to
+151
| // let (aggregatorAddr, _) = deploy_syscall( | ||
| // Aggregator::TEST_CLASS_HASH.try_into().unwrap(), 0, calldata.span(), false | ||
| // ) | ||
| // .unwrap(); |
There was a problem hiding this comment.
We can remove this right?
chris-de-leon-cll
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Starknet foundry to run the tests in the main chainlink package.
snforge test