Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ctf #522

Merged
merged 8 commits into from
Sep 12, 2024
Merged

upgrade ctf #522

merged 8 commits into from
Sep 12, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 11, 2024

image

Comment on lines +508 to +513
// K8s imports are weird
github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.14.0
github.com/prometheus/common => github.com/prometheus/common v0.42.0

// type func(a Label, b Label) bool of func(a, b Label) bool {…} does not match inferred type func(a Label, b Label) int for func(a E, b E) int
github.com/prometheus/prometheus => github.com/prometheus/prometheus v0.47.2-0.20231010075449-4b9c19fe5510
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from chainlink-solana to make this compile 😞

Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some changes that also need to be ported over too

here's a few of them (not sure if this is comprehensive)

cc @augustbleeds

@augustbleeds
Copy link
Collaborator

Hey 👋 , what's the context of these changes and what's ctf?

For the PRs that @aalu1418 is mentioning, are they needed before this PR merged in or just required at some later date.

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 11, 2024

Just TestOCRBasic failing:

13:58:56.72 DBG Validating test config
      error validating test config: chainlink image config validation failed: chainlink image name must be set

@aalu1418
Copy link
Collaborator

CTF is chainlink-testing-framework
the changes i mentioned needed can be added within this PR otherwise it will continue to fail

did this the testconfig changes ever get ported to starknet? smartcontractkit/chainlink-solana#817
this might also be needed
cc @lukaszcl

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 11, 2024

CTF is chainlink-testing-framework the changes i mentioned needed can be added within this PR otherwise it will continue to fail

Am I missing something?

@aalu1418
Copy link
Collaborator

Am I missing something?

potentially the testconfig changes? but it could just be the .github workflow changes that are in the PR i linked 🤔

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 11, 2024

potentially the testconfig changes? but it could just be the .github workflow changes that are in the PR i linked 🤔

I don't see an equivalent workflow in this repo, but I was missing the field change in the nil check 🤞

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 11, 2024

Still failing the same way. Where do we set the chainlink image?

skudasov
skudasov previously approved these changes Sep 12, 2024
@cl-sonarqube-production
Copy link

@skudasov skudasov self-requested a review September 12, 2024 10:22
@jmank88 jmank88 merged commit 41b8046 into develop Sep 12, 2024
22 checks passed
@jmank88 jmank88 deleted the ctf-lib branch September 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants