-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade ctf #522
upgrade ctf #522
Conversation
jmank88
commented
Sep 11, 2024
•
edited
Loading
edited
// K8s imports are weird | ||
github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.14.0 | ||
github.com/prometheus/common => github.com/prometheus/common v0.42.0 | ||
|
||
// type func(a Label, b Label) bool of func(a, b Label) bool {…} does not match inferred type func(a Label, b Label) int for func(a E, b E) int | ||
github.com/prometheus/prometheus => github.com/prometheus/prometheus v0.47.2-0.20231010075449-4b9c19fe5510 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from chainlink-solana to make this compile 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some changes that also need to be ported over too
here's a few of them (not sure if this is comprehensive)
- [automated] bump e2e test deps to match chainlink/integration-tests chainlink-solana#842 (this is the ctf => ctf/lib change which is already done)
- [automated] bump e2e test deps to match chainlink/integration-tests chainlink-solana#840 (some method changes)
Hey 👋 , what's the context of these changes and what's ctf? For the PRs that @aalu1418 is mentioning, are they needed before this PR merged in or just required at some later date. |
Just
|
CTF is chainlink-testing-framework did this the testconfig changes ever get ported to starknet? smartcontractkit/chainlink-solana#817 |
Am I missing something? |
potentially the testconfig changes? but it could just be the .github workflow changes that are in the PR i linked 🤔 |
I don't see an equivalent workflow in this repo, but I was missing the field change in the nil check 🤞 |
Still failing the same way. Where do we set the chainlink image? |
Quality Gate passedIssues Measures |