Skip to content

Update event indexer and txn indexer to insert txDigest as a hex string #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update event indexer and txn indexer to insert txDigest as a hex string #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d115b91
update event indexer and txn indexer to insert txDigest as a hex string
faisal-chainlink Nov 3, 2025
501a3e8
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 4, 2025
2190478
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 4, 2025
6d6ea4f
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 5, 2025
c040282
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 6, 2025
849dd4b
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 10, 2025
201a9d0
Merge branch 'develop' into fix/tx-digest-hex
faisal-chainlink Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions relayer/chainreader/indexer/events_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package indexer

import (
"context"
"encoding/base64"
"encoding/hex"
"errors"
"fmt"
Expand Down Expand Up @@ -311,15 +312,29 @@ eventLoop:
// normalize the data, convert snake case to camel case
normalizedData := convertMapKeysToCamelCase(event.ParsedJson)

// Convert the txDigest to hex
txDigestHex := event.Id.TxDigest
if base64Bytes, err := base64.StdEncoding.DecodeString(txDigestHex); err == nil {
hexTxId := hex.EncodeToString(base64Bytes)
txDigestHex = "0x" + hexTxId
}

blockHashBytes, err := base64.StdEncoding.DecodeString(block.TxDigest)
if err != nil {
eIndexer.logger.Errorw("Failed to decode block hash", "error", err)
// fallback
blockHashBytes = []byte(block.TxDigest)
}

// Convert event to database record
record := database.EventRecord{
EventAccountAddress: selector.Package,
EventHandle: eventHandle,
EventOffset: offset,
TxDigest: event.Id.TxDigest,
TxDigest: txDigestHex,
BlockVersion: 0,
BlockHeight: fmt.Sprintf("%d", block.Height),
BlockHash: []byte(block.TxDigest),
BlockHash: blockHashBytes,
// Sui returns block.Timestamp in ms; convert to seconds for consistency with CCIP readers.
BlockTimestamp: block.Timestamp / 1000,
Data: normalizedData.(map[string]any),
Expand Down
19 changes: 17 additions & 2 deletions relayer/chainreader/indexer/transactions_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package indexer

import (
"context"
"encoding/base64"
"encoding/hex"
"errors"
"fmt"
Expand Down Expand Up @@ -424,13 +425,27 @@ func (tIndexer *TransactionsIndexer) syncTransmitterTransactions(ctx context.Con
continue
}

// Convert the txDigest to hex
txDigestHex := transactionRecord.Digest
if base64Bytes, err := base64.StdEncoding.DecodeString(txDigestHex); err == nil {
hexTxId := hex.EncodeToString(base64Bytes)
txDigestHex = "0x" + hexTxId
}
Copy link
Collaborator

@FelixFan1992 FelixFan1992 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider what happens when err is not nil?

Copy link
Collaborator

@FelixFan1992 FelixFan1992 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we can safely assume that transactionRecord.Digest is going to be valid

Copy link
Collaborator Author

@faisal-chainlink faisal-chainlink Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely assume it is always there. The thing that I want to check is if the core node currently assumes this to be a base64 string when getting events, if that's the case, we need to make a small change in core as well. cc @stackman27

Copy link
Collaborator

@FelixFan1992 FelixFan1992 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's wait for his input

Copy link
Contributor

@stackman27 stackman27 Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both fields are expected as bytes, i think decoded hex is better

type Head struct {
	Height string
	Hash   []byte
	// Timestamp is in Unix time
	Timestamp uint64
}

type Sequence struct {
	// This way we can retrieve past/future sequences (EVM log events) very granularly, but still hide the chain detail.
	Cursor string
	TxHash []byte
	Head
	Data any
}


blockHashBytes, err := base64.StdEncoding.DecodeString(checkpointResponse.Digest)
if err != nil {
tIndexer.logger.Errorw("Failed to decode block hash", "error", err)
// fallback
blockHashBytes = []byte(checkpointResponse.Digest)
}

record := database.EventRecord{
EventAccountAddress: eventAccountAddress,
EventHandle: eventHandle,
EventOffset: 0,
TxDigest: transactionRecord.Digest,
TxDigest: txDigestHex,
BlockHeight: checkpointResponse.SequenceNumber,
BlockHash: []byte(checkpointResponse.Digest),
BlockHash: blockHashBytes,
BlockTimestamp: blockTimestamp,
Data: executionStateChanged,
}
Expand Down
Loading