reduce test flakiness #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixFan1992
approved these changes
Nov 5, 2025
stackman27
pushed a commit
that referenced
this pull request
Nov 9, 2025
author John <[email protected]> 1761594583 +0000 committer stackman27 <[email protected]> 1762678591 -0800 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAAEoAAAAac2stc3NoLWVkMjU1MTlAb3BlbnNzaC5jb20AAAAgdaXuLB b9V//YDZCrAQyDYGyPXpi9XddzrslRZlQFQxwAAAAEc3NoOgAAAANnaXQAAAAAAAAABnNo YTUxMgAAAGcAAAAac2stc3NoLWVkMjU1MTlAb3BlbnNzaC5jb20AAABAkeraZQbnwzQSyX R0Tc/R8bRlLc0MIi53wB+Fie3GDFXNHEYnAaSiWTAmSwNxarjAmr1As9PlnPfraP77xX+t DgEAA5s3 -----END SSH SIGNATURE----- progress computed digest progress working with dry run digest working upgrade working upgrade nit add existence check for get_domain (#147) add unblock functions in upgrade registry (#150) check report context length (#146) * check report context length * check report context length Update ownership Ops and Changesets (#116) * add ownership operations * fix transfer ops * refactor ops to handle mcms ownership * add mcms optional deployment in deploy chain cs * add operations to registry * register ops in cs * add mcms ops to registry * use mcms from deployment if not in state * remove proposals returned * split accept ownership proposal generation * fixes in accept ownership proposal. update mcms * add working accept ownership tests * wip add modules * remove add modules step * fix tests * fix tests * fix more tests * add missing op to registry * fix tests * move role verification feat(e2e): Feequoter mcms e2e tests (#113) Calculate refill (#142) * update calculate refills * tests * update versions * update sha check token pool has been unregistered before destroy (#154) * check token pool has been unregistered before destroy * build * upgrade sui version * update version * update sha add ops support for unblock functions (#155) Chore: Update how CR transforms events to use types from configs (#149) * add transformation for events when sync to transform any []byte field into hex * remove debug log * remove foreful conversion of []any to hex * update codec to include slice/array to string(hex) conversion * extend chainreader test * update counter test contract and associated bindings * remove stale test * allow overriding the event return type from configs * add test case for CCIPMessageSent event in CR * add ExpectedEventType usage to QueryKeyWithMetadata * merge * add test to QueryKeyWithMetadata * add testing methods to mock offramp contract strengthen receiver checks (#162) fix(contracts): offramp::mcms_set_ocr3_configs decoding fix (#163) store and check token pool package id to coin metadata (#161) * store and check token pool package id to coin metadata * update go binding fix set_pool (#165) * fix set_pool * update for usdc Add MCMS transfer and execute ownership (#156) Token pool MCMS tests (#157) * add support for typeargs in mcms calls * point mcms to typeargs PR * accept ownership prop of token pools test * add missing pool ops * add config proposal tests for TPs * update mcms to latest tidy modules * move ccip suite setup to common. add parallel in independent tests * add tps to address book * add managed token deploy cs * reenable set pool tests feat(ops): Add MCMS to Ramp Operations (#134) * feat(ops): Add MCMS to Ramp Operations * fix(testCCIPOwnership): Finish transfer of onRamp and offRamp * test(offramp): Add offramp tests * fix(encoder): hack fix for vector<vector<address>> on encoder * test(offramp): add offramp tests * add assertions * rebase remove register pool by admin for pools (#166) * remove register pool by admin for pools * update ops Remove key from OwnableState (#152) * Remove key from OwnableState * Regen bindings --------- Co-authored-by: FelixFan1992 <[email protected]> Remove key from OwnableState (#152) * Remove key from OwnableState * Regen bindings --------- Co-authored-by: FelixFan1992 <[email protected]> Add `data` to CCIPAdminProof (#132) * Add `data` to CCIPAdminProof * Regen bindings * Fix USDC token pool tests add a rebalancer in LR token pool (#151) * add a rebalancer in LR token pool * update ops * fix * fix build * fix test * update * update Remove typeproof from ExecutingCallbackParams (#153) * Remove typeproof from ExecutingCallbackParams * Add Publisher in OwnerCap Dynamic field (#158) feat(ops): Add MCMS to Router Ops (#135) * feat(ops): Add MCMS to Router Ops * feat(tests): add tests for router bump default values (#170) * bump default * nit Add TAR tests through MCMS (#168) * add tar tests * use execute transfer own seq MCMS rebalancer cap support (#148) fix usdc token pool (#173) fix usdc token pool mcms (#174) add version check to new fee quoter func (#175) * add version check to new fee quoter func * initialize upgrade registry first apply several small fixes (#176) * apply several small fixes * fix fix timestamp (#178) validate token receiver between hot potato & extra args (#177) add a helper to get all dest chains from router (#182) small fixes (#184) remove get token decimals (#183) small improvements for osh (#185) Transfer UpgradeCap with OwnerCap, Use LinkedTable for signed hashes (#171) * Use LinkedTable for signed hashes storage * Transfer OwnerCap and UpgradeCap (If present) in MCMS * BCS serialize package address OwnerCap needed when initialize token pools (#180) * OwnerCap needed when initialize token pools * Amend ops to add ownercap in initialize add some view functions (#186) * add some view functions * more view function fixes * fix * fix * fix `Publisher` needed when registering pools (#188) * `Publisher` needed when registering pools * Fix bindings apply several small fixes (#189) update managed token (#191) Add `PublisherWrapper` auth to registering receivers (#190) Add MCMS and other functions (#192) Disallow sending to zero address (#179) * validate token receiver between hot potato & extra args * disallow sending to 0 address * update * remove Sui Max Data (#181) * sui max data * logs * nit apply several small fixes (#203) * apply several small fixes * fix test cleanups more cleanup sui isolated config nit offramp upgrade nit compile at fix for ccip receiver fix reciever registry handle upgrade nit fix offramp case bind during contract upgrade get parent object from original pkgID fix balance exponent value (#202) add if statement to check length of results in the case of converting tuple to struct (#198) fix bug in chainreader when transforming results from events query (#197) MCMS liquidity operations (#205) BCS deserialize chain id, add checks (#193) * BCS deserialize chain id, add checks * Serialize empty data * Update MCMS to BCS serialize object inputs * Update MCMS unit test * Update bindings * Update comment MCMS test update pointtag and related docs to ensure that FieldName is optional (#195) implement print/string interfaces for private key singer to avoid printing it (#194) feat(deployment): Refactor sui state (#204) * refactor(deployment): refactor sui state - add tests * cleanup and reorganize state and load * save token symbol as pool label * lint imports * refactor state * fix MCMSExecuteTransferOwnership changeset * go mod tidy * bump go.md update CR to enable renaming event Data fields along with a test (#209) Co-authored-by: Sishir Giri <[email protected]> remove usage of updated package IDs in events indexing flow; Sui events are always emitted with original package ID (#196) Add opts nil check (#211) Co-authored-by: FelixFan1992 <[email protected]> Use a named logger instance in Loop Reader (#199) * add if statement to check length of results in the case of converting tuple to struct * add named logger to loop reader update events_indexer to attempt a single event insert at a time if batching fails (#207) fetch the latest package ID for CCIP correctly in the offramp execution flow (#200) add message and metadata hash tests (#214) check length of returned packages list in GetLatestPackageId call (#206) add a lock around event config access in transactions_indexer (#208) Co-authored-by: FelixFan1992 <[email protected]> Co-authored-by: John <[email protected]> Bump MCMS (#213) * Bump MCMS * Add DeployerStateObj field * Add DeployerStateObj field --------- Co-authored-by: FelixFan1992 <[email protected]> Package protect proof (#216) reduce test flakiness (#210) * test flakiness * Trigger Build * more test * reduce timeout time * Trigger Build * only msg tests --------- Co-authored-by: FelixFan1992 <[email protected]> Fix ChainReader GLV for upgrades (#212) * glv for upgrades * faisal suggestion * use counter module * router module * nit rebased extend timeout refetch coin changeState update Fix: update PTB client method for fetching coins (#215) * update get coins method to fetch all coins and add a query coins method * update ptb client tests * update fake / mock clients --------- Co-authored-by: John <[email protected]> Co-authored-by: FelixFan1992 <[email protected]> Misc items (#217) * update several misc items * update new img fetch sender coin after send fetch sender coin after enque wait for local exec go back to using devnet fully change to wait for local exec sort by version Update MCMS, lock release token pool readme (#220) update token pool operations (#219) * update token pool operations * update * update ops * update cross verify token pool package id & remove arm (#224) * cross verify token pool package id * remove get_arm confirmer changes more logs cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: 701e659e63b1b969bd4ebc4bb3eb6489577885dd