Addressed feedback and fixed linting

common/txmgr/confirmer.go

@@ -1001,7 +1001,7 @@ func (ec *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) han
 		return ec.txStore.DeleteInProgressAttempt(ctx, attempt)
 	case client.TerminallyStuck:
 		// A transaction could broadcast successfully but then be considered terminally stuck on another attempt
-		// Even though the transaction can succeeed under different circumstances, we want to purge this transaction as soon as we get this error
+		// Even though the transaction can succeed under different circumstances, we want to purge this transaction as soon as we get this error
 		lggr.Errorw("terminally stuck transaction detected", "err", sendError.Error())
 		ec.SvcErrBuffer.Append(sendError)
 		// Create a purge attempt for tx

core/chains/evm/client/errors_test.go

@@ -290,7 +290,7 @@ func Test_Eth_Errors(t *testing.T) {
 	})
 
 	t.Run("Metis gas price errors", func(t *testing.T) {
-		err := evmclient.NewSendErrorS("primary websocket (wss://ws-mainnet.metis.io) call failed: gas price too low: 18000000000 wei, use at least tx.gasPrice = 19500000000 wei")
+		err = evmclient.NewSendErrorS("primary websocket (wss://ws-mainnet.metis.io) call failed: gas price too low: 18000000000 wei, use at least tx.gasPrice = 19500000000 wei")
 		assert.True(t, err.L2FeeTooLow(clientErrors))
 		err = newSendErrorWrapped("primary websocket (wss://ws-mainnet.metis.io) call failed: gas price too low: 18000000000 wei, use at least tx.gasPrice = 19500000000 wei")
 		assert.True(t, err.L2FeeTooLow(clientErrors))
@@ -302,7 +302,7 @@ func Test_Eth_Errors(t *testing.T) {
 	})
 
 	t.Run("moonriver errors", func(t *testing.T) {
-		err := evmclient.NewSendErrorS("primary http (http://***REDACTED***:9933) call failed: submit transaction to pool failed: Pool(Stale)")
+		err = evmclient.NewSendErrorS("primary http (http://***REDACTED***:9933) call failed: submit transaction to pool failed: Pool(Stale)")
 		assert.True(t, err.IsNonceTooLowError(clientErrors))
 		assert.False(t, err.IsTransactionAlreadyInMempool(clientErrors))
 		assert.False(t, err.Fatal(clientErrors))

core/chains/evm/txmgr/broadcaster_test.go

@@ -529,11 +529,11 @@ func TestEthBroadcaster_ProcessUnstartedEthTxs_Success(t *testing.T) {
 				return tx.Nonce() == uint64(346) && tx.Value().Cmp(big.NewInt(243)) == 0
 			}), fromAddress).Return(commonclient.Fatal, errors.New(terminallyStuckError)).Once()
 
-			// Do the thing
+			// Start processing unstarted transactions
 			retryable, err := eb.ProcessUnstartedTxs(tests.Context(t), fromAddress)
 			assert.NoError(t, err)
 			assert.False(t, retryable)
-		
+
 			dbTx, err := txStore.FindTxWithAttempts(ctx, etx.ID)
 			require.NoError(t, err)
 			assert.Equal(t, txmgrcommon.TxFatalError, dbTx.State)

core/chains/evm/txmgr/confirmer_test.go

@@ -2713,7 +2713,7 @@ func TestEthConfirmer_RebroadcastWhereNecessary_TerminallyStuckError(t *testing.
 			return tx.Nonce() == uint64(*etx.Sequence)
 		}), fromAddress).Return(commonclient.Successful, nil).Once()
 
-		// Do the thing
+		// Start processing transactions for rebroadcast
 		require.NoError(t, ec.RebroadcastWhereNecessary(tests.Context(t), currentHead))
 		var err error
 		etx, err = txStore.FindTxWithAttempts(ctx, etx.ID)