Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/2.4.0 -> master #10287

Merged
merged 151 commits into from
Aug 22, 2023
Merged

release/2.4.0 -> master #10287

merged 151 commits into from
Aug 22, 2023

Conversation

chainchad
Copy link
Collaborator

Digestible diff for release/2.4.0 -> develop.

Andrei Smirnov and others added 30 commits June 28, 2023 14:23
* Functions: connection handler prep work

* S4 methods

* FunctionsConnector tests

* Fixed broken test

* Addressed PR feedback

* Allowlist refactor

* Addressed PR feedback
* squashing all commits

* integrated changes from #9677

* fixed lint error

* fixed lint error

* fixed proto name conflict

* ran protoc

* addressed feedback

* Addressed feedback

* Added decryptionQueueConfig to integration test jobspec

* Fix bugs from merge conflict resolution
* Initializing S4 plugin

* Addressed PR feedback
* log event provider (wip)

* fixes 2.1 integration

* log event provider + buffer

* log event provider: integration test

* adding a temp copy from ocr2keepers

* increase timeout to stablize test

TODO: figure this out w/o timeouts at all

* use log struct for check data

* move log event provider int test into evm21

* extract 2.1 int tests

* aligned default config

should fix backfill test instability

* fixes and tests

* lint

* extract logprovider package

* extract log packer

* stablize test

* apply lookback buffer after rate limiting

* stablize tests

* log struct packing
* build AutomationUtils contract and update tests

* use report struct as rawReport bytes

* update wrappers

* add Log struct

---------

Co-authored-by: FelixFan1992 <[email protected]>
* Move KeySpecific field

* Fix test

* Fix test

* Change KeySpecificMaxPrice to MaxPriceKey

* Change MaxPriceKey to PriceMaxKey
1. Set Message.Sender as a non-serializable field.
2. Add Message.Receiver field. Because messageID is scoped to a user, nodes need to set receiver to that user’s address to make sure responses can be uniquely attributed to users and also to prove to the user that it is in fact a response to their message.
3. Fix ValidateSignature(). I mistakenly assumed that previous logic was enough to fully validate a signature but we always need to validate the expected sender. Renamed the function to ExtractSigner() to avoid any confusion.
4. Perform message validation before calling handler methods, as suggested by @pinebit. Even though there are theoretical use cases that might not need it, I don’t think they are going to be implemented in the near future.
5. Changing HandleGatewayMessage() attribute back to full message instead of just body. This will be needed for a very real use case, where nodes want to share received messages among each other, within the OCR round. It’s also consistent with the Gateway Handler interface.
6. Fix broken scripts.
* [BCF-2261] Split up config/v2; rename config/v2 -> config/toml

* Rename Env -> Var; EnvSecret -> Secret

* utils/configutils -> utils/config

* Make coreDefaultsTOML private again

* Address review comments

* LooppHostName -> LOOPPHostName
…9700)

Bumps [smartcontractkit/chainlink-github-actions](https://github.com/smartcontractkit/chainlink-github-actions) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/smartcontractkit/chainlink-github-actions/releases)
- [Commits](smartcontractkit/chainlink-github-actions@v2.2.0...ad22fbd)

---
updated-dependencies:
- dependency-name: smartcontractkit/chainlink-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Krage <[email protected]>
* AutomationForwarder.t.sol tests

* foundry refactor

* UpkeepMock used

* performUpkeep boolean state change check

* updated versions to 0.8.16

* use UpkeepCounter.sol as mock
…ig/toml. (#9753)

* Move NodePoolConfig to config.go

* Move chain_scoped to config package

* Rename evm/config/v2 -> evm/config/toml

* Run make generate
* use utils abi for un/packing reports and triggers

* fixed unpacking

* lint

* mark failing tests

* comments

* comment

* Revert "mark failing tests"

This reverts commit 4a8d0f8.

* fix log provider tests

* packer tests

* encoder tests

* test all trigger cases

* add tests
End to end work uncovered a problem where a plugin would not start
because the prom server couldn't get a port. Ultimately this was caused
by duplicate names in the LoopRegistry.

This change makes names unique and, to ensure better error handling, it
changes the Register function to error if called more than once. The latter
change will make the problem much more clear should it ever happen again.
* Full integration of threshold plugin with Functions

* fixed port conflict

* Addressed feedback & added test helpers

* Fixed test to use helper function

* ran make gomodtidy
* Adding SelectLatestBlockNumberEventSigsAddrsWithConfs that returns only block number, without returning entire evm logs dataset

* Minor formatting fix
* parallelize mercury calls

* parallelize mercury requests in pipeline

* refactor

* fix tests

* address comments
* refactored

* yarn prettier + go wrappers
samsondav
samsondav previously approved these changes Aug 22, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Reliability Rating on New Code (is worse than A)
Failed condition 4.5% 4.54% Duplicated Lines (%) on New Code (is greater than 3%)
Failed condition 4 New Blocker Issues (is greater than 0)
Failed condition 6 New Major Issues (is greater than 5)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@chainchad chainchad merged commit c6c6273 into master Aug 22, 2023
118 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.