Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE-1902 Use single, large runner for core tests #10604

Merged
merged 3 commits into from
Sep 20, 2023
Merged

RE-1902 Use single, large runner for core tests #10604

merged 3 commits into from
Sep 20, 2023

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Sep 12, 2023 •
edited
Loading

Summary

  • Simplifies CI graph by a significant amount
  • Tests are run closely to how we'd run them locally
  • 18 -> 2 runners used per core test invocation
  • Total test time gets around a 40% reduction on avg for core test pipeline
  • We should hit rate limits on the GHA issued token less often now, since there's much less duplication of work that involves the GH API being used

Before

image
image

After

image
image

@HenryNguyen5 HenryNguyen5 force-pushed the chore/condense_core_tests branch 8 times, most recently from 017e7f5 to d1f7ccf Compare September 14, 2023 17:40
@HenryNguyen5 HenryNguyen5 force-pushed the chore/condense_core_tests branch 4 times, most recently from 5535398 to 9caf2ea Compare September 20, 2023 21:08
@HenryNguyen5 HenryNguyen5 marked this pull request as ready for review September 20, 2023 21:33
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Sep 20, 2023
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Sep 20, 2023
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Sep 20, 2023
@HenryNguyen5 HenryNguyen5 changed the title Test out single shard, large runner tests Use single, large runner for core tests Sep 20, 2023
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Sep 20, 2023
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Sep 20, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

tateexon
tateexon approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@tateexon tateexon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HenryNguyen5 HenryNguyen5 changed the title Use single, large runner for core tests RE-1902 Use single, large runner for core tests Sep 20, 2023
@jmank88 jmank88 added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2023
@jmank88 jmank88 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into develop with commit 347541a Sep 20, 2023
82 checks passed
@jmank88 jmank88 deleted the chore/condense_core_tests branch September 20, 2023 22:36
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tateexon tateexon tateexon approved these changes

@jmank88 jmank88 jmank88 approved these changes

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenryNguyen5 @jmank88 @tateexon