improve check block old detection #10733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6251807839 |
FelixFan1992
previously approved these changes
Sep 20, 2023
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6252525163 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6252531059 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6252617110 |
FelixFan1992
previously approved these changes
Sep 20, 2023
FelixFan1992
approved these changes
Sep 20, 2023
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6252653392 |
amirylm
approved these changes
Sep 20, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saw on matic, some payloads were stuck in retry loop as they were getting
missing trie nodeerroradding that string to error check. Don't fully like the approach of handling error strings which got us here, open to better solutions
We're not fully relying on just latest-checkBlock > checkBlockTooOldRange because the range can differ from chains, and the existing 128 range was too small for arbitrum, causing lots of payloads to error out early