-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces and skeleton methods for ChainReader EVM POC #10990
Merged
Merged
Commits on Dec 5, 2023
-
Implement skeleton interfaces, structs, & methods for ChainReader EVM…
… POC - Read ChainReader config in from RelayConfig - Add some initialization and validation relay skeletons - Use medianProviderWrapper instead of passing medianContract separately This avoids us having to modify the signature of NewMedianFactory, which would require further modifications to all non-evm repos and chainlink-relay - Add chain_reader_test.go with some basic relay tests Co-authored-by: Jordan Krage <[email protected]> - Add chain reader config validation - Add chain reader config validation tests - Add config for chain reader median contract to cr validation testcases - Add unimplemented Encode(), Decode(), GetMaxEncodingSize(), GetMaxDecodingSize() - Add ChainReader() method to mock provider for plugin test - Rename relaymercury.ChainReader to MercuryChainReader, resolve name collisions - Add tests for errors during ChainReader construction - Propagate InvalidConfig & any other errors back to client We should ignore Unimplemented until node ops have been given ample time to migrate to the new job spec (including a section for ChainReader config) so that we can remove the old product-specific MedianContract component from MedianProvider. All other errors we can immediately start passing back to the client, letting the core node decide how to handle them (eg. displaying an "invalid job spec" message to the UI if the RelayConfig was invalid or the ContractID missing)
Configuration menu - View commit details
-
Copy full SHA for 1cd875f - Browse repository at this point
Copy the full SHA 1cd875fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6cab63 - Browse repository at this point
Copy the full SHA b6cab63View commit details -
Merge remote-tracking branch 'origin/develop' into BCF-2612-ChainRead…
…er-EVM-POC # Conflicts: # core/services/ocr2/plugins/ocr2vrf/coordinator/coordinator_test.go
Configuration menu - View commit details
-
Copy full SHA for 25c0f26 - Browse repository at this point
Copy the full SHA 25c0f26View commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for baa2373 - Browse repository at this point
Copy the full SHA baa2373View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd35aaa - Browse repository at this point
Copy the full SHA bd35aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for aacc6b2 - Browse repository at this point
Copy the full SHA aacc6b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea694b3 - Browse repository at this point
Copy the full SHA ea694b3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.