Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RE-2009] Bump action references #11067

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Oct 24, 2023

Should replace the following dependabot PRs: #11051, #10562, #10855, #10359

Workflows initiated by dependabot submitted PRs do not have access to protected environments, and so their workflows will fail due to not having access to secrets. This PR consolidates a few dependabot changes pertinent to node20 upgrades.

Changes:

  • actions/checkout: 3.* -> 4 (and pinned some SHAs)
  • actions/setup-node: 3 -> 4 (and pinned some SHAs)
  • aws-actions/configure-aws-credentials: 2 -> 4
  • aws-actions/amazon-ecr-login: 1 -> 2

I had to leave a single reference of actions/checkout as integration tests were failing. I've included a comment on that specific instance. For posterity - here's a link to the failed run when node20 is expected to be available.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@erikburt erikburt changed the title Bump actions/checkout from 3 to 4 Bump action references Oct 24, 2023
dependabot bot and others added 2 commits October 24, 2023 11:58
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...3df4ab1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@erikburt erikburt force-pushed the chore/dependabot-action-updates branch from 4487350 to 07075bf Compare October 24, 2023 18:58
@erikburt erikburt self-assigned this Oct 24, 2023
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@erikburt erikburt force-pushed the chore/dependabot-action-updates branch from 07075bf to 4d6ce7e Compare October 24, 2023 19:01
@erikburt erikburt requested a review from a team October 24, 2023 20:13
@erikburt erikburt marked this pull request as ready for review October 24, 2023 20:15
jmank88
jmank88 previously approved these changes Oct 24, 2023
@erikburt erikburt changed the title Bump action references [RE-2009] Bump action references Oct 24, 2023
chainchad
chainchad previously approved these changes Oct 24, 2023
tateexon
tateexon previously approved these changes Oct 24, 2023
* develop:
  Bump version and update CHANGELOG for core v2.7.0 (#11072)
  VRF-664:add Slack notification for VRF v2 Plus WASP test (#11063)
  fix several npm audit issues (#11080)
  Pass docker image and version to ClNode in E2E tests (#11082)
  core/internal/testutils/configtest: consolidate v2 and toml packages in to configtest (#11081)
  [BCF-2725] Add the repository name to the flakey test runner output (#11078)
  Bump breaking NPM deps (#11003)
  Fix redundant "replacing abandoned tx" logs (#11019)
  (chore): Reduce contracts solhint warnings by ignoring Functions v1.0.0 production code (#11069)
  (test): Add Functions test harnesses & additional foundry unit tests (#11011)
  Use correct git commit sha as build metadata from manual workflow dispatches (#11068)
  (chore): FUN-1024 - Deprecate Chainlink Functions v0 contract code (#11049)
  move testing contracts from integration-tests/contracts/ethereum/src to contracts/src/v0.8/automation/testhelpers (#11046)
@erikburt erikburt dismissed stale reviews from tateexon, chainchad, and jmank88 via e8826f8 October 25, 2023 17:49
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chainchad chainchad added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit 4464dff Oct 25, 2023
108 checks passed
@chainchad chainchad deleted the chore/dependabot-action-updates branch October 25, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants