-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump geth v1.14.11; rm hacks #11809
Merged
bump geth v1.14.11; rm hacks #11809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
@jmank88 please do not merge until I run |
krehermann
approved these changes
Nov 12, 2024
Merge conflicts resolved. PTAL |
RensR
approved these changes
Nov 12, 2024
karen-stepanyan
approved these changes
Nov 12, 2024
makramkd
approved these changes
Nov 12, 2024
jmank88
requested review from
justinfranco,
akuzni2,
namikmesic,
martin-cll,
agparadiso,
infiloop2,
anirudhwarrier,
leeyikjiun and
FelixFan1992
November 12, 2024 13:35
connorwstein
approved these changes
Nov 12, 2024
eutopian
approved these changes
Nov 12, 2024
samsondav
approved these changes
Nov 12, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-3338
Bumping geth to v1.14.11, which brings a new simulated backend API from v1.13.14 and breaks our usage of the old one. The simulated backends are:
chainlink/core/chains/evm/logpoller/helper_test.go
Line 50 in 916514e
Failing Tests
These tests are currently skipped due to disruptive failures. TODO: Open tickets to address.
features
features_test.go
blockhashstore
feeder_test.go
ccip
clo_ccip_integration_test.go
integration_legacy_test.go
integration_test.go
ocr2keeper
integration_21_test.go
vrf
integration_v2_plus_test.go
integration_v2_test.go
listener_v2_log_listener_test.go