VRF-897: refactoring VRF v2 and V2 Plus e2e tests

[iljapavlovs]

PR covers multiple tasks:

• https://smartcontract-it.atlassian.net/browse/VRF-947 - BHS Load Test
  • added TestVRFV2BHSPerformance and TestVRFV2PlusBHSPerformance tests where we:
    • underfund sub
    • perform rand requests continuously for bhs_test_duration
    • wait 256 blocks
    • fund the sub
    • check that all requests are fulfilled
• https://smartcontract-it.atlassian.net/browse/VRF-897 - run smoke tests against existing env
  • creating SetupVRFV2Universe for v2 and v2plus and adding to each test. If use_existing_env is true, then it will not deploy new contracts, but will use specified vrf coordinator and keyhash
• https://smartcontract-it.atlassian.net/browse/VRF-948 - isolate tests - each test should create separate sub and consumer
  • added SetupNewConsumersAndSubs to the start of each test so that each test creates its own sub and consumer. Also, removed sub and consumer deployment from the main setup env script
• ongoing refactoring of VRF V2 and V2Plus tests
  • separating code into separate files for logging, setup_steps, errors in integration-tests/actions/vrf/vrfv2plus/, integration-tests/actions/vrf/vrfv2

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[ibrajer]

How about killing most of the if-else nesting by reversing the logic:

// just for this case do this...
if *testConfig.VRFv2.General.UseExistingEnv &&  *testConfig.VRFv2.ExistingEnvConfig.ExistingEnvConfig. CreateFundSubsAndAddConsumers {
	consumer, err := env.ContractLoader.LoadVRFv2LoadTestConsumer(*commonExistingEnvConfig.ConsumerAddress)
	if err != nil {
		return nil, nil, fmt.Errorf("err: %w", err)
	}
	consumers = append(consumers, consumer)
	subIDs = append(subIDs, *testConfig.VRFv2.ExistingEnvConfig.SubID)
                     return subIDs, consumers, nil
}

// for all other cases, do this...
consumers, subIDs, err = SetupNewConsumersAndSubs(
	env,
	coordinator,
	testConfig,
	linkToken,
	numberOfConsumerContractsToDeployAndAddToSub,
	numberOfSubToCreate,
	l,
)
if err != nil {
	return nil, nil, fmt.Errorf("err: %w", err)
}
return subIDs, consumers, nil

[iljapavlovs]

yeah, just I usually prefer the most easiest solution

[ibrajer]

Remember the comment where I suggested to reorganize the code by flipping the logic? This can be applied here as well.

[ibrajer]

LGTM, left some comments, but nothing that can't be addressed later or fixed/updated in the next PR.

[cl-sonarqube-production]

Quality Gate passed

Issues
27 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.3% Duplication on New Code

See analysis details on SonarQube