Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXM In-memory: step 3-01-SetBroadcastBeforeBlockNum #12219

Merged

Conversation

poopoothegorilla
Copy link
Contributor

NOTES:

  • Implement SetBroadcastBeforeBlockNum Method

Parent:

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

Copy link
Contributor

@DylanTinianov DylanTinianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DylanTinianov
Copy link
Contributor

I added populating enabledAddresses (same as another other PR) to get the tests passing for me locally. Looks good now.

@poopoothegorilla poopoothegorilla marked this pull request as ready for review April 1, 2024 18:18
@poopoothegorilla poopoothegorilla requested a review from a team as a code owner April 1, 2024 18:18
@cl-sonarqube-production
Copy link

@poopoothegorilla poopoothegorilla merged commit 3c4554d into jtw/step-3-01 Apr 1, 2024
109 of 114 checks passed
@poopoothegorilla poopoothegorilla deleted the jtw/step-3-01-set-broadcast-before-blocknum branch April 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants