TXM In-memory: step 3-02-PruneUnstartedTxQueue #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poopoothegorilla
temporarily deployed
to
sdlc
GitHub Actions
Inactive
|
I see that you haven't updated any README files. Would it make sense to do so? |
amit-momin
reviewed
Mar 13, 2024
amit-momin
reviewed
Mar 22, 2024
|
Comment on lines
+183
to
+208
| for _, txState := range txStates { | ||
| switch txState { | ||
| case TxUnstarted: | ||
| filter2 := func(tx *txmgrtypes.Tx[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, SEQ, FEE]) bool { | ||
| if tx.State != TxUnstarted { | ||
| return false | ||
| } | ||
| return filter(tx) | ||
| } | ||
| txs = append(txs, as._findTxs(as.allTxs, filter2, txIDs...)...) | ||
| case TxInProgress: | ||
| if as.inprogressTx != nil && filter(as.inprogressTx) { | ||
| txs = append(txs, *as.inprogressTx) | ||
| } | ||
| case TxUnconfirmed: | ||
| txs = append(txs, as._findTxs(as.unconfirmedTxs, filter, txIDs...)...) | ||
| case TxConfirmedMissingReceipt: | ||
| txs = append(txs, as._findTxs(as.confirmedMissingReceiptTxs, filter, txIDs...)...) | ||
| case TxConfirmed: | ||
| txs = append(txs, as._findTxs(as.confirmedTxs, filter, txIDs...)...) | ||
| case TxFatalError: | ||
| txs = append(txs, as._findTxs(as.fatalErroredTxs, filter, txIDs...)...) | ||
| default: | ||
| panic("findTxs: unknown transaction state") | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be also be optimized if we use map[State]map[ID][]*Tx
There was a problem hiding this comment.
great point! I think that could be useful for the next iteration of this work. This code is still pretty EVM specific. your suggestion is a bit more generalized and might be a good next step for this. With all that being said I think we should hold off on that work for a future refactor.
DylanTinianov
approved these changes
Mar 28, 2024
amit-momin
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES:
Parent: