Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXM In-memory: step 3-04-MarkAllConfirmedMissingReceipt #12232

Merged
merged 8 commits into from
Mar 22, 2024
Merged

TXM In-memory: step 3-04-MarkAllConfirmedMissingReceipt #12232

merged 8 commits into from
Mar 22, 2024

Conversation

poopoothegorilla
Copy link
Contributor

NOTES:

  • Implements MarkAllConfirmedMissingReceipt

Parent:

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

prashantkumar1982
prashantkumar1982 reviewed Mar 20, 2024
View reviewed changes
common/txmgr/inmemory_store.go
@@ -334,7 +336,53 @@ func (ms *inMemoryStore[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) FindT
return nil, nil
}
func (ms *inMemoryStore[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) MarkAllConfirmedMissingReceipt(ctx context.Context, chainID CHAIN_ID) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of EVM refactor, in future, this function should go away into chain-specific code. The TxStore shouldn't need to know nonce specific logic which it is doing here currently.
Not for now though.

prashantkumar1982
prashantkumar1982 reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please move to main review channel for final rounds

@prashantkumar1982 prashantkumar1982 marked this pull request as ready for review March 20, 2024 01:29
@prashantkumar1982 prashantkumar1982 requested review from a team as code owners March 20, 2024 01:29
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@prashantkumar1982 prashantkumar1982 merged commit 9d59e02 into jtw/step-3-04 Mar 22, 2024
111 of 114 checks passed
@prashantkumar1982 prashantkumar1982 deleted the jtw/step-3-04-mark-all-confirmed-missing-receipt branch March 22, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poopoothegorilla @prashantkumar1982 @amit-momin