[KS-87] Generic workflow engine #12461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add hardcoded YAML workflow and parsing * Execute an individual step * Execute an individual step
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
e0591a0
to
bbdac51
Compare
|
I see that you haven't updated any README files. Would it make sense to do so? |
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
bbdac51
to
e5f277e
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
e5f277e
to
3fb38d8
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
3fb38d8
to
da4b39b
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
da4b39b
to
f1f16f0
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
f1f16f0
to
d0b2137
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
d0b2137
to
8d8ae47
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
8d8ae47
to
e90f8a8
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
e90f8a8
to
6a33827
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
6a33827
to
539e083
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
539e083
to
d17b0c2
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
d17b0c2
to
4c2a220
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
4c2a220
to
b7e188b
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
34bf71c
to
7e75cd1
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
7e75cd1
to
2b14b85
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
2b14b85
to
d9b6032
Compare
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
d9b6032
to
6f096ba
Compare
…ments' into ks-87-workflow-engine-scheduler
cedric-cordenier
force-pushed
the
ks-87-workflow-engine-scheduler
branch
from
617d3cf
to
54bb815
Compare
bolekk
approved these changes
Mar 22, 2024
| newWorkerTimeout time.Duration | ||
|
|
||
| // Used for testing to wait for an execution to complete | ||
| xxxExecutionFinished chan string |
There was a problem hiding this comment.
Not a huge fan of these kind of hooks. Can we maybe use a mock target in tests and wait for it to be called?
There was a problem hiding this comment.
Same... I initially used a mock target but that leads to a race since the engine will do some processing (like updating internal state) after the target has been called. It also won't notify you if the workflow has errored for some reason.
There was a problem hiding this comment.
going to let someone more experienced like @bolekk to approve, LGTM though!
| // 2. Registers each step's capability to this workflow | ||
| // 3. Registers for trigger events now that all capabilities are resolved | ||
| // | ||
| // Steps 1 and 2 are retried every 5 seconds until successful. |
There was a problem hiding this comment.
Do we want a retry limit?
There was a problem hiding this comment.
Hmmm... probably not -- I think this should be a temporary thing, and if we're not able to initialize the workflow we should keep trying since the NOP has chosen to run the job.
| return nil | ||
| } | ||
|
|
||
| // If the capability is already cached, that means we've already registered it |
There was a problem hiding this comment.
Suggested change
| // If the capability is already cached, that means we've already registered it | |
| // If the capability instance already exists, that means we've already registered it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.